From 413eadfac9386c6f84333de286053a405b52be46 Mon Sep 17 00:00:00 2001 From: David Blaikie Date: Wed, 3 Sep 2014 17:41:05 +0000 Subject: [PATCH] unique_ptrify MachOUniversalBinary::create git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217052 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/Object/MachOUniversal.h | 3 ++- lib/Object/Binary.cpp | 3 +-- lib/Object/MachOUniversal.cpp | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/llvm/Object/MachOUniversal.h b/include/llvm/Object/MachOUniversal.h index 491565ba8e5..949010be44e 100644 --- a/include/llvm/Object/MachOUniversal.h +++ b/include/llvm/Object/MachOUniversal.h @@ -85,7 +85,8 @@ public: }; MachOUniversalBinary(MemoryBufferRef Souce, std::error_code &EC); - static ErrorOr create(MemoryBufferRef Source); + static ErrorOr> + create(MemoryBufferRef Source); object_iterator begin_objects() const { return ObjectForArch(this, 0); diff --git a/lib/Object/Binary.cpp b/lib/Object/Binary.cpp index d9fef8be8e1..d23ee590569 100644 --- a/lib/Object/Binary.cpp +++ b/lib/Object/Binary.cpp @@ -63,8 +63,7 @@ ErrorOr> object::createBinary(MemoryBufferRef Buffer, case sys::fs::file_magic::bitcode: return ObjectFile::createSymbolicFile(Buffer, Type, Context); case sys::fs::file_magic::macho_universal_binary: - return ErrorOr>( - MachOUniversalBinary::create(Buffer)); + return MachOUniversalBinary::create(Buffer); case sys::fs::file_magic::unknown: case sys::fs::file_magic::windows_resource: // Unrecognized object file format. diff --git a/lib/Object/MachOUniversal.cpp b/lib/Object/MachOUniversal.cpp index 3deef4b7f65..e310a71ba91 100644 --- a/lib/Object/MachOUniversal.cpp +++ b/lib/Object/MachOUniversal.cpp @@ -97,14 +97,14 @@ std::error_code MachOUniversalBinary::ObjectForArch::getAsArchive( void MachOUniversalBinary::anchor() { } -ErrorOr +ErrorOr> MachOUniversalBinary::create(MemoryBufferRef Source) { std::error_code EC; std::unique_ptr Ret( new MachOUniversalBinary(Source, EC)); if (EC) return EC; - return Ret.release(); + return std::move(Ret); } MachOUniversalBinary::MachOUniversalBinary(MemoryBufferRef Source,