diff --git a/include/llvm/Target/TargetInstrInfo.h b/include/llvm/Target/TargetInstrInfo.h index bec37a62bf1..e54ca204670 100644 --- a/include/llvm/Target/TargetInstrInfo.h +++ b/include/llvm/Target/TargetInstrInfo.h @@ -427,10 +427,9 @@ public: return false; } - /// IgnoreRegisterClassBarriers - Returns true if pre-register allocation - /// live interval splitting pass should ignore barriers of the specified - /// register class. - virtual bool IgnoreRegisterClassBarriers(const TargetRegisterClass *RC) const{ + /// isSafeToMoveRegClassDefs - Return true if it's safe to move a machine + /// instruction that defines the specified register class. + virtual bool isSafeToMoveRegClassDefs(const TargetRegisterClass *RC) const { return true; } diff --git a/lib/CodeGen/PreAllocSplitting.cpp b/lib/CodeGen/PreAllocSplitting.cpp index dfff87a3d7b..ef2cfdb9828 100644 --- a/lib/CodeGen/PreAllocSplitting.cpp +++ b/lib/CodeGen/PreAllocSplitting.cpp @@ -1128,7 +1128,10 @@ PreAllocSplitting::SplitRegLiveIntervals(const TargetRegisterClass **RCs, // by the current barrier. SmallVector Intervals; for (const TargetRegisterClass **RC = RCs; *RC; ++RC) { - if (TII->IgnoreRegisterClassBarriers(*RC)) + // FIXME: If it's not safe to move any instruction that defines the barrier + // register class, then it means there are some special dependencies which + // codegen is not modelling. Ignore these barriers for now. + if (!TII->isSafeToMoveRegClassDefs(*RC)) continue; std::vector &VRs = MRI->getRegClassVirtRegs(*RC); for (unsigned i = 0, e = VRs.size(); i != e; ++i) { diff --git a/lib/Target/X86/X86InstrInfo.cpp b/lib/Target/X86/X86InstrInfo.cpp index 8e3985f0998..577884969b3 100644 --- a/lib/Target/X86/X86InstrInfo.cpp +++ b/lib/Target/X86/X86InstrInfo.cpp @@ -2483,11 +2483,11 @@ ReverseBranchCondition(SmallVectorImpl &Cond) const { } bool X86InstrInfo:: -IgnoreRegisterClassBarriers(const TargetRegisterClass *RC) const { - // FIXME: Ignore bariers of x87 stack registers for now. We can't +isSafeToMoveRegClassDefs(const TargetRegisterClass *RC) const { + // FIXME: Return false for x87 stack register classes for now. We can't // allow any loads of these registers before FpGet_ST0_80. - return RC == &X86::CCRRegClass || RC == &X86::RFP32RegClass || - RC == &X86::RFP64RegClass || RC == &X86::RFP80RegClass; + return !(RC == &X86::CCRRegClass || RC == &X86::RFP32RegClass || + RC == &X86::RFP64RegClass || RC == &X86::RFP80RegClass); } const TargetRegisterClass *X86InstrInfo::getPointerRegClass() const { diff --git a/lib/Target/X86/X86InstrInfo.h b/lib/Target/X86/X86InstrInfo.h index 077de56a5d5..eba0baf3cae 100644 --- a/lib/Target/X86/X86InstrInfo.h +++ b/lib/Target/X86/X86InstrInfo.h @@ -406,10 +406,9 @@ public: virtual bool ReverseBranchCondition(SmallVectorImpl &Cond) const; - /// IgnoreRegisterClassBarriers - Returns true if pre-register allocation - /// live interval splitting pass should ignore barriers of the specified - /// register class. - bool IgnoreRegisterClassBarriers(const TargetRegisterClass *RC) const; + /// isSafeToMoveRegClassDefs - Return true if it's safe to move a machine + /// instruction that defines the specified register class. + bool isSafeToMoveRegClassDefs(const TargetRegisterClass *RC) const; const TargetRegisterClass *getPointerRegClass() const;