6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-08-08 19:25:47 +00:00
Code Issues Projects Releases Wiki Activity

Use switch on VT instead of Type* comparisons.

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@57551 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chris Lattner
2008-10-15 04:32:45 +00:00
parent 51ccb3deba
commit 45ac17f521
1 changed files with 18 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
lib/Target/X86/X86FastISel.cpp
View File

@@ -519,36 +519,35 @@ bool X86FastISel::X86SelectLoad(Instruction *I) {
static unsigned X86ChooseCmpOpcode(MVT VT) { static unsigned X86ChooseCmpOpcode(MVT VT) {
switch (VT.getSimpleVT()) { switch (VT.getSimpleVT()) {
case MVT::i8: return X86::CMP8rr; default: return 0;
case MVT::i8: return X86::CMP8rr;
case MVT::i16: return X86::CMP16rr; case MVT::i16: return X86::CMP16rr;
case MVT::i32: return X86::CMP32rr; case MVT::i32: return X86::CMP32rr;
case MVT::i64: return X86::CMP64rr; case MVT::i64: return X86::CMP64rr;
case MVT::f32: return X86::UCOMISSrr; case MVT::f32: return X86::UCOMISSrr;
case MVT::f64: return X86::UCOMISDrr; case MVT::f64: return X86::UCOMISDrr;
default: break;
} }
return 0;
} }
/// X86ChooseCmpImmediateOpcode - If we have a comparison with RHS as the RHS /// X86ChooseCmpImmediateOpcode - If we have a comparison with RHS as the RHS
/// of the comparison, return an opcode that works for the compare (e.g. /// of the comparison, return an opcode that works for the compare (e.g.
/// CMP32ri) otherwise return 0. /// CMP32ri) otherwise return 0.
static unsigned X86ChooseCmpImmediateOpcode(ConstantInt *RHSC) { static unsigned X86ChooseCmpImmediateOpcode(MVT VT, ConstantInt *RHSC) {
if (RHSC->getType() == Type::Int8Ty) switch (VT.getSimpleVT()) {
return X86::CMP8ri;
if (RHSC->getType() == Type::Int16Ty)
return X86::CMP16ri;
if (RHSC->getType() == Type::Int32Ty)
return X86::CMP32ri;
// 64-bit comparisons are only valid if the immediate fits in a 32-bit sext
// field.
if (RHSC->getType() == Type::Int64Ty &&
(int)RHSC->getSExtValue() == RHSC->getSExtValue())
return X86::CMP64ri32;
// Otherwise, we can't fold the immediate into this comparison. // Otherwise, we can't fold the immediate into this comparison.
return 0; default: return 0;
case MVT::i8: return X86::CMP8ri;
case MVT::i16: return X86::CMP16ri;
case MVT::i32: return X86::CMP32ri;
case MVT::i64:
// 64-bit comparisons are only valid if the immediate fits in a 32-bit sext
// field.
if (RHSC->getType() == Type::Int64Ty &&
(int)RHSC->getSExtValue() == RHSC->getSExtValue())
return X86::CMP64ri32;
return 0;
}
} }
bool X86FastISel::X86FastEmitCompare(Value *Op0, Value *Op1, MVT VT) { bool X86FastISel::X86FastEmitCompare(Value *Op0, Value *Op1, MVT VT) {
@@ -559,7 +558,7 @@ bool X86FastISel::X86FastEmitCompare(Value *Op0, Value *Op1, MVT VT) {
// the compare is an immediate that we can fold into this compare, use // the compare is an immediate that we can fold into this compare, use
// CMPri, otherwise use CMPrr. // CMPri, otherwise use CMPrr.
if (ConstantInt *Op1C = dyn_cast<ConstantInt>(Op1)) { if (ConstantInt *Op1C = dyn_cast<ConstantInt>(Op1)) {
if (unsigned CompareImmOpc = X86ChooseCmpImmediateOpcode(Op1C)) { if (unsigned CompareImmOpc = X86ChooseCmpImmediateOpcode(VT, Op1C)) {
BuildMI(MBB, TII.get(CompareImmOpc)).addReg(Op0Reg) BuildMI(MBB, TII.get(CompareImmOpc)).addReg(Op0Reg)
.addImm(Op1C->getSExtValue()); .addImm(Op1C->getSExtValue());
return true; return true;