From 464d66497146423f0d5bb32caed24f28ee6afbc9 Mon Sep 17 00:00:00 2001 From: Venkatraman Govindaraju Date: Fri, 7 Feb 2014 07:34:49 +0000 Subject: [PATCH] [Sparc] Emit correct encoding for atomic instructions. Also, add support for parsing CAS instructions to test the CAS encoding. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200963 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/Sparc/AsmParser/SparcAsmParser.cpp | 19 ++++++++++++++++++- lib/Target/Sparc/SparcInstr64Bit.td | 2 +- lib/Target/Sparc/SparcInstrFormats.td | 7 +++++-- lib/Target/Sparc/SparcInstrInfo.td | 16 ++++++++-------- test/MC/Sparc/sparc-atomic-instructions.s | 19 +++++++++++++++++++ 5 files changed, 51 insertions(+), 12 deletions(-) create mode 100644 test/MC/Sparc/sparc-atomic-instructions.s diff --git a/lib/Target/Sparc/AsmParser/SparcAsmParser.cpp b/lib/Target/Sparc/AsmParser/SparcAsmParser.cpp index ca27b40e73b..7c3ddb0e382 100644 --- a/lib/Target/Sparc/AsmParser/SparcAsmParser.cpp +++ b/lib/Target/Sparc/AsmParser/SparcAsmParser.cpp @@ -546,7 +546,24 @@ parseOperand(SmallVectorImpl &Operands, Parser.getTok().getLoc())); Parser.Lex(); // Eat the [ - ResTy = parseMEMOperand(Operands); + if (Mnemonic == "cas" || Mnemonic == "casx") { + SMLoc S = Parser.getTok().getLoc(); + if (getLexer().getKind() != AsmToken::Percent) + return MatchOperand_NoMatch; + Parser.Lex(); // eat % + + unsigned RegNo, RegKind; + if (!matchRegisterName(Parser.getTok(), RegNo, RegKind)) + return MatchOperand_NoMatch; + + Parser.Lex(); // Eat the identifier token. + SMLoc E = SMLoc::getFromPointer(Parser.getTok().getLoc().getPointer()-1); + Operands.push_back(SparcOperand::CreateReg(RegNo, RegKind, S, E)); + ResTy = MatchOperand_Success; + } else { + ResTy = parseMEMOperand(Operands); + } + if (ResTy != MatchOperand_Success) return ResTy; diff --git a/lib/Target/Sparc/SparcInstr64Bit.td b/lib/Target/Sparc/SparcInstr64Bit.td index 9146098a230..a5b48f90340 100644 --- a/lib/Target/Sparc/SparcInstr64Bit.td +++ b/lib/Target/Sparc/SparcInstr64Bit.td @@ -415,7 +415,7 @@ def SETHIXi : F2_1<0b100, // ATOMICS. let Predicates = [Is64Bit], Constraints = "$swap = $rd" in { - def CASXrr: F3_1<3, 0b111110, + def CASXrr: F3_1_asi<3, 0b111110, 0b10000000, (outs I64Regs:$rd), (ins I64Regs:$rs1, I64Regs:$rs2, I64Regs:$swap), "casx [$rs1], $rs2, $rd", diff --git a/lib/Target/Sparc/SparcInstrFormats.td b/lib/Target/Sparc/SparcInstrFormats.td index c5409bae26d..b38a663bd3c 100644 --- a/lib/Target/Sparc/SparcInstrFormats.td +++ b/lib/Target/Sparc/SparcInstrFormats.td @@ -100,9 +100,8 @@ class F3 pattern> // Specific F3 classes: SparcV8 manual, page 44 // -class F3_1 opVal, bits<6> op3val, dag outs, dag ins, +class F3_1_asi opVal, bits<6> op3val, bits<8> asi, dag outs, dag ins, string asmstr, list pattern> : F3 { - bits<8> asi = 0; // asi not currently used bits<5> rs2; let op = opVal; @@ -113,6 +112,10 @@ class F3_1 opVal, bits<6> op3val, dag outs, dag ins, let Inst{4-0} = rs2; } +class F3_1 opVal, bits<6> op3val, dag outs, dag ins, string asmstr, + list pattern> : F3_1_asi; + class F3_2 opVal, bits<6> op3val, dag outs, dag ins, string asmstr, list pattern> : F3 { bits<13> simm13; diff --git a/lib/Target/Sparc/SparcInstrInfo.td b/lib/Target/Sparc/SparcInstrInfo.td index 4aebdae6a7a..94d2719d20e 100644 --- a/lib/Target/Sparc/SparcInstrInfo.td +++ b/lib/Target/Sparc/SparcInstrInfo.td @@ -935,19 +935,19 @@ let Predicates = [HasV9], hasSideEffects = 1, rd = 0, rs1 = 0b01111 in def MEMBARi : F3_2<2, 0b101000, (outs), (ins i32imm:$simm13), "membar $simm13", []>; -let Constraints = "$val = $rd" in { +let Constraints = "$val = $dst" in { def SWAPrr : F3_1<3, 0b001111, - (outs IntRegs:$rd), (ins IntRegs:$val, MEMrr:$addr), - "swap [$addr], $rd", - [(set i32:$rd, (atomic_swap_32 ADDRrr:$addr, i32:$val))]>; + (outs IntRegs:$dst), (ins MEMrr:$addr, IntRegs:$val), + "swap [$addr], $dst", + [(set i32:$dst, (atomic_swap_32 ADDRrr:$addr, i32:$val))]>; def SWAPri : F3_2<3, 0b001111, - (outs IntRegs:$rd), (ins IntRegs:$val, MEMri:$addr), - "swap [$addr], $rd", - [(set i32:$rd, (atomic_swap_32 ADDRri:$addr, i32:$val))]>; + (outs IntRegs:$dst), (ins MEMri:$addr, IntRegs:$val), + "swap [$addr], $dst", + [(set i32:$dst, (atomic_swap_32 ADDRri:$addr, i32:$val))]>; } let Predicates = [HasV9], Constraints = "$swap = $rd" in - def CASrr: F3_1<3, 0b111100, + def CASrr: F3_1_asi<3, 0b111100, 0b10000000, (outs IntRegs:$rd), (ins IntRegs:$rs1, IntRegs:$rs2, IntRegs:$swap), "cas [$rs1], $rs2, $rd", diff --git a/test/MC/Sparc/sparc-atomic-instructions.s b/test/MC/Sparc/sparc-atomic-instructions.s new file mode 100644 index 00000000000..5c46067ea3b --- /dev/null +++ b/test/MC/Sparc/sparc-atomic-instructions.s @@ -0,0 +1,19 @@ +! RUN: llvm-mc %s -arch=sparcv9 -show-encoding | FileCheck %s + + ! CHECK: membar 15 ! encoding: [0x81,0x43,0xe0,0x0f] + membar 15 + + ! CHECK: stbar ! encoding: [0x81,0x43,0xc0,0x00] + stbar + + ! CHECK: swap [%i0+%l6], %o2 ! encoding: [0xd4,0x7e,0x00,0x16] + swap [%i0+%l6], %o2 + + ! CHECK: swap [%i0+32], %o2 ! encoding: [0xd4,0x7e,0x20,0x20] + swap [%i0+32], %o2 + + ! CHECK: cas [%i0], %l6, %o2 ! encoding: [0xd5,0xe6,0x10,0x16] + cas [%i0], %l6, %o2 + + ! CHECK: casx [%i0], %l6, %o2 ! encoding: [0xd5,0xf6,0x10,0x16] + casx [%i0], %l6, %o2