From 47b0c0a9a0d920917e1fb10ac1c851c6e3b8aa27 Mon Sep 17 00:00:00 2001 From: Benjamin Kramer Date: Fri, 7 Jun 2013 16:13:49 +0000 Subject: [PATCH] R600: Fix a potential iterator invalidation issue. As a bonus this reduces the loop from O(n^2) to O(n). git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@183532 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/R600/R600OptimizeVectorRegisters.cpp | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/lib/Target/R600/R600OptimizeVectorRegisters.cpp b/lib/Target/R600/R600OptimizeVectorRegisters.cpp index 9d237bb7a04..0c123a101e7 100644 --- a/lib/Target/R600/R600OptimizeVectorRegisters.cpp +++ b/lib/Target/R600/R600OptimizeVectorRegisters.cpp @@ -198,11 +198,9 @@ MachineInstr *R600VectorRegMerger::RebuildVector( .addReg(SubReg) .addImm(Chan); UpdatedRegToChan[SubReg] = Chan; - for (std::vector::iterator RemoveIt = UpdatedUndef.begin(), - RemoveE = UpdatedUndef.end(); RemoveIt != RemoveE; ++ RemoveIt) { - if (*RemoveIt == Chan) - UpdatedUndef.erase(RemoveIt); - } + UpdatedUndef.erase( + std::remove(UpdatedUndef.begin(), UpdatedUndef.end(), Chan), + UpdatedUndef.end()); DEBUG(dbgs() << " ->"; Tmp->dump();); (void)Tmp; SrcVec = DstReg;