6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-06-14 14:24:05 +00:00
Code Issues Projects Releases Wiki Activity

change Mangler::makeNameProper to return its result in a SmallVector

Browse Source 
instead of returning it in an std::string.  Based on this change:

1. Change TargetLoweringObjectFileCOFF::getCOFFSection to take a StringRef
2. Change a bunch of targets to call makeNameProper with a smallstring,
   making several of them *much* more efficient.
3. Rewrite Mangler::makeNameProper to not build names and then prepend
   prefixes, not use temporary std::strings, and to avoid other crimes.



git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@93298 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chris Lattner
2010-01-13 06:38:18 +00:00
parent 36e69ae3c1
commit 4813035b72
10 changed files with 170 additions and 132 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
lib/Target/TargetLoweringObjectFile.cpp
View File

@ -492,16 +492,15 @@ getELFKindForNamedSection(const char *Name, SectionKind K) {
}
static unsigned
getELFSectionType(const char *Name, SectionKind K) {
static unsigned getELFSectionType(StringRef Name, SectionKind K) {
if (strcmp(Name, ".init_array") == 0)
if (Name == ".init_array")
return MCSectionELF::SHT_INIT_ARRAY;
if (strcmp(Name, ".fini_array") == 0)
if (Name == ".fini_array")
return MCSectionELF::SHT_FINI_ARRAY;
if (strcmp(Name, ".preinit_array") == 0)
if (Name == ".preinit_array")
return MCSectionELF::SHT_PREINIT_ARRAY;
if (K.isBSS() || K.isThreadBSS())
@ -577,10 +576,12 @@ SelectSectionForGlobal(const GlobalValue *GV, SectionKind Kind,
// into a 'uniqued' section name, create and return the section now.
if (GV->isWeakForLinker()) {
const char *Prefix = getSectionPrefixForUniqueGlobal(Kind);
std::string Name = Mang->makeNameProper(GV->getNameStr());
SmallString<128> Name;
Name.append(Prefix, Prefix+strlen(Prefix));
Mang->makeNameProper(Name, GV->getName());
return getELFSection((Prefix+Name).c_str(),
getELFSectionType((Prefix+Name).c_str(), Kind),
return getELFSection(Name.str(),
getELFSectionType(Name.str(), Kind),
getELFSectionFlags(Kind),
Kind);
}
@ -983,7 +984,7 @@ TargetLoweringObjectFileCOFF::~TargetLoweringObjectFileCOFF() {
const MCSection *TargetLoweringObjectFileCOFF::
getCOFFSection(const char *Name, bool isDirective, SectionKind Kind) const {
getCOFFSection(StringRef Name, bool isDirective, SectionKind Kind) const {
// Create the map if it doesn't already exist.
if (UniquingMap == 0)
UniquingMap = new MachOUniqueMapTy();
@ -1078,8 +1079,9 @@ SelectSectionForGlobal(const GlobalValue *GV, SectionKind Kind,
// into a 'uniqued' section name, create and return the section now.
if (GV->isWeakForLinker()) {
const char *Prefix = getCOFFSectionPrefixForUniqueGlobal(Kind);
std::string Name = Mang->makeNameProper(GV->getNameStr());
return getCOFFSection((Prefix+Name).c_str(), false, Kind);
SmallString<128> Name(Prefix, Prefix+strlen(Prefix));
Mang->makeNameProper(Name, GV->getNameStr());
return getCOFFSection(Name.str(), false, Kind);
}
if (Kind.isText())