6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-08-05 13:26:55 +00:00
Code Issues Projects Releases Wiki Activity

Fix MCDataAtom never calling remap when adding data.

Browse Source 
This patch fixes a small mistake in MCDataAtom::addData() where it doesn't ever
call remap():

-  if (Data.size() > Begin - End - 1)
+  if (Data.size() > End + 1 - Begin)
     remap(Begin, End + 1);

This is currently not visible because of another bug is the disassembler, so
the patch includes a unit test.

Patch by Stephen Checkoway.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@192823 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Rafael Espindola
2013-10-16 18:26:16 +00:00
parent 2906b519d1
commit 49978e6125
7 changed files with 63 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
unittests/MC/CMakeLists.txt Normal file
View File

@@ -0,0 +1,11 @@
set(LLVM_LINK_COMPONENTS
MC
)
set(MCSources
MCAtomTest.cpp
)
add_llvm_unittest(MCTests
${MCSources}
)

31
unittests/MC/MCAtomTest.cpp Normal file
View File

@@ -0,0 +1,31 @@
//===- llvm/unittest/MC/MCAtomTest.cpp - Instructions unit tests ----------===//
//
// The LLVM Compiler Infrastructure
//
// This file is distributed under the University of Illinois Open Source
// License. See LICENSE.TXT for details.
//
//===----------------------------------------------------------------------===//
#include "llvm/MC/MCAtom.h"
#include "llvm/MC/MCModule.h"
#include "gtest/gtest.h"
namespace llvm {
namespace {
TEST(MCAtomTest, MCDataSize) {
MCModule M;
MCDataAtom *Atom = M.createDataAtom(0, 0);
EXPECT_EQ(uint64_t(0), Atom->getEndAddr());
Atom->addData(0);
EXPECT_EQ(uint64_t(0), Atom->getEndAddr());
Atom->addData(1);
EXPECT_EQ(uint64_t(1), Atom->getEndAddr());
Atom->addData(2);
EXPECT_EQ(uint64_t(2), Atom->getEndAddr());
EXPECT_EQ(size_t(3), Atom->getData().size());
}
} // end anonymous namespace
} // end namespace llvm

15
unittests/MC/Makefile Normal file
View File

@@ -0,0 +1,15 @@
##===- unittests/IR/Makefile -------------------------------*- Makefile -*-===##
#
# The LLVM Compiler Infrastructure
#
# This file is distributed under the University of Illinois Open Source
# License. See LICENSE.TXT for details.
#
##===----------------------------------------------------------------------===##
LEVEL = ../..
TESTNAME = MC
LINK_COMPONENTS := MC
include $(LEVEL)/Makefile.config
include $(LLVM_SRC_ROOT)/unittests/Makefile.unittest