mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2024-08-23 17:29:19 +00:00
It is safe to remat a value killed by phis.
The source live range is recomputed using shrinkToUses() which does handle phis correctly. The hasPHIKill() condition was relevant in the old days when ReMaterializeTrivialDef() tried to recompute the live range itself. The shrinkToUses() function will mark the original def as dead when no more uses and phi kills remain. It is then removed by runOnMachineFunction(). git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@139781 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
parent
573a32d487
commit
4ea24e993f
@ -805,9 +805,7 @@ bool RegisterCoalescer::ReMaterializeTrivialDef(LiveInterval &SrcInt,
|
||||
LiveInterval::iterator SrcLR = SrcInt.FindLiveRangeContaining(CopyIdx);
|
||||
assert(SrcLR != SrcInt.end() && "Live range not found!");
|
||||
VNInfo *ValNo = SrcLR->valno;
|
||||
// If other defs can reach uses of this def, then it's not safe to perform
|
||||
// the optimization.
|
||||
if (ValNo->isPHIDef() || ValNo->isUnused() || ValNo->hasPHIKill())
|
||||
if (ValNo->isPHIDef() || ValNo->isUnused())
|
||||
return false;
|
||||
MachineInstr *DefMI = LIS->getInstructionFromIndex(ValNo->def);
|
||||
if (!DefMI)
|
||||
|
Loading…
Reference in New Issue
Block a user