From 4eeee88e912cc03208b5ead91563a7519ec4ab73 Mon Sep 17 00:00:00 2001 From: Saleem Abdulrasool Date: Fri, 10 Jan 2014 04:38:31 +0000 Subject: [PATCH] ARM IAS: support implicit immediate 0s for {LD,ST}R{B,}T The ARM ARM indicates the mnemonics as follows: ldrbt{}{} , [], {, #+/-} ldrt{}{} , [] {, #+/-} strbt{}{} , [] {, #} strt{}{} , [] {, #+/-} This improves the parser to deal with the implicit immediate 0 for the mnemonics as per the specification. Thanks to Joerg Sonnenberger for the tests! git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198914 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/ARM/ARMInstrInfo.td | 72 +++++++++++++++++++++------------- test/MC/ARM/arm_addrmode2.s | 8 ++++ 2 files changed, 53 insertions(+), 27 deletions(-) diff --git a/lib/Target/ARM/ARMInstrInfo.td b/lib/Target/ARM/ARMInstrInfo.td index cbf67c96458..b80eefd398c 100644 --- a/lib/Target/ARM/ARMInstrInfo.td +++ b/lib/Target/ARM/ARMInstrInfo.td @@ -2444,23 +2444,28 @@ def LDRT_POST_REG : AI2ldstidx<1, 0, 0, (outs GPR:$Rt, GPR:$Rn_wb), let DecoderMethod = "DecodeAddrMode2IdxInstruction"; } -def LDRT_POST_IMM : AI2ldstidx<1, 0, 0, (outs GPR:$Rt, GPR:$Rn_wb), - (ins addr_offset_none:$addr, am2offset_imm:$offset), - IndexModePost, LdFrm, IIC_iLoad_ru, - "ldrt", "\t$Rt, $addr, $offset", - "$addr.base = $Rn_wb", []> { +class LDRTImmediate + : AI2ldstidx<1, 0, 0, (outs GPR:$Rt, GPR:$Rn_wb), iops, + IndexModePost, LdFrm, IIC_iLoad_ru, + "ldrt", args, "$addr.base = $Rn_wb", []> { // {12} isAdd // {11-0} imm12/Rm bits<14> offset; bits<4> addr; let Inst{25} = 0; - let Inst{23} = offset{12}; + let Inst{23} = !if(has_offset, offset{12}, 1); let Inst{21} = 1; // overwrite let Inst{19-16} = addr; - let Inst{11-0} = offset{11-0}; + let Inst{11-0} = !if(has_offset, offset{11-0}, 0); let DecoderMethod = "DecodeAddrMode2IdxInstruction"; } +def LDRT_POST_IMM + : LDRTImmediate<1, "\t$Rt, $addr, $offset", + (ins addr_offset_none:$addr, am2offset_imm:$offset)>; +def LDRT_POST_IMM_0 + : LDRTImmediate<0, "\t$Rt, $addr", (ins addr_offset_none:$addr)>; + def LDRBT_POST_REG : AI2ldstidx<1, 1, 0, (outs GPR:$Rt, GPR:$Rn_wb), (ins addr_offset_none:$addr, am2offset_reg:$offset), IndexModePost, LdFrm, IIC_iLoad_bh_ru, @@ -2480,23 +2485,28 @@ def LDRBT_POST_REG : AI2ldstidx<1, 1, 0, (outs GPR:$Rt, GPR:$Rn_wb), let DecoderMethod = "DecodeAddrMode2IdxInstruction"; } -def LDRBT_POST_IMM : AI2ldstidx<1, 1, 0, (outs GPR:$Rt, GPR:$Rn_wb), - (ins addr_offset_none:$addr, am2offset_imm:$offset), +class LDRBTImmediate + : AI2ldstidx<1, 1, 0, (outs GPR:$Rt, GPR:$Rn_wb), iops, IndexModePost, LdFrm, IIC_iLoad_bh_ru, - "ldrbt", "\t$Rt, $addr, $offset", - "$addr.base = $Rn_wb", []> { + "ldrbt", args, "$addr.base = $Rn_wb", []> { // {12} isAdd // {11-0} imm12/Rm bits<14> offset; bits<4> addr; let Inst{25} = 0; - let Inst{23} = offset{12}; + let Inst{23} = !if(has_offset, offset{12}, 1); let Inst{21} = 1; // overwrite let Inst{19-16} = addr; - let Inst{11-0} = offset{11-0}; + let Inst{11-0} = !if(has_offset, offset{11-0}, 0); let DecoderMethod = "DecodeAddrMode2IdxInstruction"; } +def LDRBT_POST_IMM + : LDRBTImmediate<1, "\t$Rt, $addr, $offset", + (ins addr_offset_none:$addr, am2offset_imm:$offset)>; +def LDRBT_POST_IMM_0 + : LDRBTImmediate<0, "\t$Rt, $addr", (ins addr_offset_none:$addr)>; + multiclass AI3ldrT op, string opc> { def i : AI3ldstidxT { +class STRBTImmediate + : AI2ldstidx<0, 1, 0, (outs GPR:$Rn_wb), iops, IndexModePost, StFrm, + IIC_iStore_bh_ru, "strbt", args, "$addr.base = $Rn_wb", []> { // {12} isAdd // {11-0} imm12/Rm bits<14> offset; bits<4> addr; let Inst{25} = 0; - let Inst{23} = offset{12}; + let Inst{23} = !if(has_offset, offset{12}, 1); let Inst{21} = 1; // overwrite let Inst{19-16} = addr; - let Inst{11-0} = offset{11-0}; + let Inst{11-0} = !if(has_offset, offset{11-0}, 0); let DecoderMethod = "DecodeAddrMode2IdxInstruction"; } +def STRBT_POST_IMM + : STRBTImmediate<1, "\t$Rt, $addr, $offset", + (ins GPR:$Rt, addr_offset_none:$addr, am2offset_imm:$offset)>; +def STRBT_POST_IMM_0 + : STRBTImmediate<0, "\t$Rt, $addr", (ins GPR:$Rt, addr_offset_none:$addr)>; + let mayStore = 1, neverHasSideEffects = 1 in { def STRT_POST_REG : AI2ldstidx<0, 0, 0, (outs GPR:$Rn_wb), (ins GPR:$Rt, addr_offset_none:$addr, am2offset_reg:$offset), @@ -2785,22 +2799,26 @@ def STRT_POST_REG : AI2ldstidx<0, 0, 0, (outs GPR:$Rn_wb), let DecoderMethod = "DecodeAddrMode2IdxInstruction"; } -def STRT_POST_IMM : AI2ldstidx<0, 0, 0, (outs GPR:$Rn_wb), - (ins GPR:$Rt, addr_offset_none:$addr, am2offset_imm:$offset), - IndexModePost, StFrm, IIC_iStore_ru, - "strt", "\t$Rt, $addr, $offset", - "$addr.base = $Rn_wb", []> { +class STRTImmediate + : AI2ldstidx<0, 0, 0, (outs GPR:$Rn_wb), iops, IndexModePost, StFrm, + IIC_iStore_ru, "strt", args, "$addr.base = $Rn_wb", []> { // {12} isAdd // {11-0} imm12/Rm bits<14> offset; bits<4> addr; let Inst{25} = 0; - let Inst{23} = offset{12}; + let Inst{23} = !if(has_offset, offset{12}, 1); let Inst{21} = 1; // overwrite let Inst{19-16} = addr; - let Inst{11-0} = offset{11-0}; + let Inst{11-0} = !if(has_offset, offset{11-0}, 0); let DecoderMethod = "DecodeAddrMode2IdxInstruction"; } + +def STRT_POST_IMM + : STRTImmediate<1, "\t$Rt, $addr, $offset", + (ins GPR:$Rt, addr_offset_none:$addr, am2offset_imm:$offset)>; +def STRT_POST_IMM_0 + : STRTImmediate<0, "\t$Rt, $addr", (ins GPR:$Rt, addr_offset_none:$addr)>; } diff --git a/test/MC/ARM/arm_addrmode2.s b/test/MC/ARM/arm_addrmode2.s index ca99233b9b5..a4fb9356db1 100644 --- a/test/MC/ARM/arm_addrmode2.s +++ b/test/MC/ARM/arm_addrmode2.s @@ -4,27 +4,35 @@ @ CHECK: ldrt r1, [r0], r2 @ encoding: [0x02,0x10,0xb0,0xe6] @ CHECK: ldrt r1, [r0], r2, lsr #3 @ encoding: [0xa2,0x11,0xb0,0xe6] @ CHECK: ldrt r1, [r0], #4 @ encoding: [0x04,0x10,0xb0,0xe4] +@ CHECK: ldrt r1, [r0] @ encoding: [0x00,0x10,0xb0,0xe4] @ CHECK: ldrbt r1, [r0], r2 @ encoding: [0x02,0x10,0xf0,0xe6] @ CHECK: ldrbt r1, [r0], r2, lsr #3 @ encoding: [0xa2,0x11,0xf0,0xe6] @ CHECK: ldrbt r1, [r0], #4 @ encoding: [0x04,0x10,0xf0,0xe4] +@ CHECK: ldrbt r1, [r0] @ encoding: [0x00,0x10,0xf0,0xe4] @ CHECK: strt r1, [r0], r2 @ encoding: [0x02,0x10,0xa0,0xe6] @ CHECK: strt r1, [r0], r2, lsr #3 @ encoding: [0xa2,0x11,0xa0,0xe6] @ CHECK: strt r1, [r0], #4 @ encoding: [0x04,0x10,0xa0,0xe4] +@ CHECK: strt r1, [r0] @ encoding: [0x00,0x10,0xa0,0xe4] @ CHECK: strbt r1, [r0], r2 @ encoding: [0x02,0x10,0xe0,0xe6] @ CHECK: strbt r1, [r0], r2, lsr #3 @ encoding: [0xa2,0x11,0xe0,0xe6] @ CHECK: strbt r1, [r0], #4 @ encoding: [0x04,0x10,0xe0,0xe4] +@ CHECK: strbt r1, [r0] @ encoding: [0x00,0x10,0xe0,0xe4] ldrt r1, [r0], r2 ldrt r1, [r0], r2, lsr #3 ldrt r1, [r0], #4 + ldrt r1, [r0] ldrbt r1, [r0], r2 ldrbt r1, [r0], r2, lsr #3 ldrbt r1, [r0], #4 + ldrbt r1, [r0] strt r1, [r0], r2 strt r1, [r0], r2, lsr #3 strt r1, [r0], #4 + strt r1, [r0] strbt r1, [r0], r2 strbt r1, [r0], r2, lsr #3 strbt r1, [r0], #4 + strbt r1, [r0] @ Pre-indexed @ CHECK: ldr r1, [r0, r2, lsr #3]! @ encoding: [0xa2,0x11,0xb0,0xe7]