diff --git a/include/llvm/Instruction.h b/include/llvm/Instruction.h index 45959ccc6e5..88f5ce1b262 100644 --- a/include/llvm/Instruction.h +++ b/include/llvm/Instruction.h @@ -189,7 +189,7 @@ private: void getAllMetadataImpl(SmallVectorImpl > &)const; void getAllMetadataOtherThanDebugLocImpl(SmallVectorImpl > &) const; - void removeAllMetadata(); + void clearMetadataHashEntries(); public: //===--------------------------------------------------------------------===// // Predicates and helper methods. diff --git a/lib/VMCore/Instruction.cpp b/lib/VMCore/Instruction.cpp index 9792adaaa12..05bed4c6431 100644 --- a/lib/VMCore/Instruction.cpp +++ b/lib/VMCore/Instruction.cpp @@ -49,8 +49,8 @@ Instruction::Instruction(const Type *ty, unsigned it, Use *Ops, unsigned NumOps, // Out of line virtual method, so the vtable, etc has a home. Instruction::~Instruction() { assert(Parent == 0 && "Instruction still linked in the program!"); - if (hasMetadata()) - removeAllMetadata(); + if (hasMetadataHashEntry()) + clearMetadataHashEntries(); } diff --git a/lib/VMCore/Metadata.cpp b/lib/VMCore/Metadata.cpp index 22e758763d6..023799ceb82 100644 --- a/lib/VMCore/Metadata.cpp +++ b/lib/VMCore/Metadata.cpp @@ -563,13 +563,11 @@ getAllMetadataOtherThanDebugLocImpl(SmallVectorImplMetadataStore.erase(this); - setHasMetadataHashEntry(false); - } +/// clearMetadataHashEntries - Clear all hashtable-based metadata from +/// this instruction. +void Instruction::clearMetadataHashEntries() { + assert(hasMetadataHashEntry() && "Caller should check"); + getContext().pImpl->MetadataStore.erase(this); + setHasMetadataHashEntry(false); }