diff --git a/lib/Transforms/Scalar/LoopStrengthReduce.cpp b/lib/Transforms/Scalar/LoopStrengthReduce.cpp index c4ee5237ae8..e97921237fc 100644 --- a/lib/Transforms/Scalar/LoopStrengthReduce.cpp +++ b/lib/Transforms/Scalar/LoopStrengthReduce.cpp @@ -540,7 +540,7 @@ Value *BasedUser::InsertCodeForBaseAtPosition(const SCEVHandle &NewBase, // If there is no immediate value, skip the next part. if (SCEVConstant *SC = dyn_cast(Imm)) - if (SC->getValue()->isZero()) + if (SC->getValue()->isNullValue()) return Rewriter.expandCodeFor(NewBase, BaseInsertPt, OperandValToReplace->getType()); @@ -779,7 +779,7 @@ static void SeparateSubExprs(std::vector &SubExprs, SeparateSubExprs(SubExprs, SARE->getOperand(0)); } } else if (!isa(Expr) || - !cast(Expr)->getValue()->isZero()) { + !cast(Expr)->getValue()->isNullValue()) { // Do not add zero. SubExprs.push_back(Expr); } @@ -869,7 +869,7 @@ RemoveCommonExpressionsFromUseBases(std::vector &Uses) { /// static bool isZero(SCEVHandle &V) { if (SCEVConstant *SC = dyn_cast(V)) - return SC->getValue()->isZero(); + return SC->getValue()->getZExtValue() == 0; return false; } @@ -883,18 +883,17 @@ unsigned LoopStrengthReduce::CheckForIVReuse(const SCEVHandle &Stride, if (!TLI) return 0; if (SCEVConstant *SC = dyn_cast(Stride)) { - APInt SInt(SC->getValue()->getValue()); - if (SInt == 1) - return 0; + int64_t SInt = SC->getValue()->getSExtValue(); + if (SInt == 1) return 0; for (TargetLowering::legal_am_scale_iterator I = TLI->legal_am_scale_begin(), E = TLI->legal_am_scale_end(); I != E; ++I) { - APInt Scale(SInt.getBitWidth(), *I); - if (SInt.abs().ult(Scale) || SInt.srem(Scale) != 0) + unsigned Scale = *I; + if (unsigned(abs(SInt)) < Scale || (SInt % Scale) != 0) continue; std::map::iterator SI = - IVsByStride.find(SCEVUnknown::getIntegerSCEV(SInt.sdiv(Scale))); + IVsByStride.find(SCEVUnknown::getIntegerSCEV(SInt/Scale, UIntPtrTy)); if (SI == IVsByStride.end()) continue; for (std::vector::iterator II = SI->second.IVs.begin(), @@ -903,7 +902,7 @@ unsigned LoopStrengthReduce::CheckForIVReuse(const SCEVHandle &Stride, // Only reuse previous IV if it would not require a type conversion. if (isZero(II->Base) && II->Base->getType() == Ty) { IV = *II; - return Scale.getZExtValue(); + return Scale; } } } @@ -1149,14 +1148,14 @@ void LoopStrengthReduce::StrengthReduceStridedIVUsers(const SCEVHandle &Stride, // are reusing an IV, it has not been used to initialize the PHI node. // Add it to the expression used to rewrite the uses. if (!isa(CommonBaseV) || - !cast(CommonBaseV)->isZero()) + !cast(CommonBaseV)->isNullValue()) RewriteExpr = SCEVAddExpr::get(RewriteExpr, SCEVUnknown::get(CommonBaseV)); } // Now that we know what we need to do, insert code before User for the // immediate and any loop-variant expressions. - if (!isa(BaseV) || !cast(BaseV)->isZero()) + if (!isa(BaseV) || !cast(BaseV)->isNullValue()) // Add BaseV to the PHI value if needed. RewriteExpr = SCEVAddExpr::get(RewriteExpr, SCEVUnknown::get(BaseV));