mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2024-10-02 17:55:18 +00:00
Fix another case of a .comm directive without a corresponding .type
directive. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@119073 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
parent
8d63ba8260
commit
55d02f3a13
@ -409,9 +409,10 @@ void MCELFStreamer::EmitCommonSymbol(MCSymbol *Symbol, uint64_t Size,
|
|||||||
if (!BindingExplicitlySet.count(Symbol)) {
|
if (!BindingExplicitlySet.count(Symbol)) {
|
||||||
SetBinding(SD, ELF::STB_GLOBAL);
|
SetBinding(SD, ELF::STB_GLOBAL);
|
||||||
SD.setExternal(true);
|
SD.setExternal(true);
|
||||||
SetType(SD, ELF::STT_OBJECT);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
|
SetType(SD, ELF::STT_OBJECT);
|
||||||
|
|
||||||
if (GetBinding(SD) == ELF_STB_Local) {
|
if (GetBinding(SD) == ELF_STB_Local) {
|
||||||
const MCSection *Section = getAssembler().getContext().getELFSection(".bss",
|
const MCSection *Section = getAssembler().getContext().getELFSection(".bss",
|
||||||
MCSectionELF::SHT_NOBITS,
|
MCSectionELF::SHT_NOBITS,
|
||||||
|
@ -30,11 +30,24 @@
|
|||||||
// CHECK-NEXT: ('st_value', 0x00000001)
|
// CHECK-NEXT: ('st_value', 0x00000001)
|
||||||
// CHECK-NEXT: ('st_size', 0x00000001)
|
// CHECK-NEXT: ('st_size', 0x00000001)
|
||||||
|
|
||||||
|
.local common6
|
||||||
|
.comm common6,8,16
|
||||||
|
|
||||||
|
// CHECK: # Symbol 0x00000003
|
||||||
|
// CHECK-NEXT: (('st_name', 0x00000011) # 'common6'
|
||||||
|
// CHECK-NEXT: ('st_bind', 0x00000000)
|
||||||
|
// CHECK-NEXT: ('st_type', 0x00000001)
|
||||||
|
// CHECK-NEXT: ('st_other', 0x00000000)
|
||||||
|
// CHECK-NEXT: ('st_shndx', 0x00000003)
|
||||||
|
// CHECK-NEXT: ('st_value', 0x00000010)
|
||||||
|
// CHECK-NEXT: ('st_size', 0x00000008)
|
||||||
|
// CHECK-NEXT: ),
|
||||||
|
|
||||||
// Test that without an explicit .local we produce a global.
|
// Test that without an explicit .local we produce a global.
|
||||||
.type common3,@object
|
.type common3,@object
|
||||||
.comm common3,4,4
|
.comm common3,4,4
|
||||||
|
|
||||||
// CHECK: ('st_name', 0x00000011) # 'common3'
|
// CHECK: ('st_name', 0x00000019) # 'common3'
|
||||||
// CHECK-NEXT: ('st_bind', 0x00000001)
|
// CHECK-NEXT: ('st_bind', 0x00000001)
|
||||||
// CHECK-NEXT: ('st_type', 0x00000001)
|
// CHECK-NEXT: ('st_type', 0x00000001)
|
||||||
// CHECK-NEXT: ('st_other', 0x00000000)
|
// CHECK-NEXT: ('st_other', 0x00000000)
|
||||||
@ -54,7 +67,7 @@ foo:
|
|||||||
.type common4,@object
|
.type common4,@object
|
||||||
.comm common4,40,16
|
.comm common4,40,16
|
||||||
|
|
||||||
// CHECK: ('st_name', 0x0000001d) # 'common4'
|
// CHECK: ('st_name', 0x00000025) # 'common4'
|
||||||
// CHECK-NEXT: ('st_bind', 0x00000001)
|
// CHECK-NEXT: ('st_bind', 0x00000001)
|
||||||
// CHECK-NEXT: ('st_type', 0x00000001)
|
// CHECK-NEXT: ('st_type', 0x00000001)
|
||||||
// CHECK-NEXT: ('st_other', 0x00000000)
|
// CHECK-NEXT: ('st_other', 0x00000000)
|
||||||
@ -64,8 +77,8 @@ foo:
|
|||||||
|
|
||||||
.comm common5,4,4
|
.comm common5,4,4
|
||||||
|
|
||||||
// CHECK: # Symbol 0x00000008
|
// CHECK: # Symbol 0x00000009
|
||||||
// CHECK-NEXT: (('st_name', 0x00000025) # 'common5'
|
// CHECK-NEXT: (('st_name', 0x0000002d) # 'common5'
|
||||||
// CHECK-NEXT: ('st_bind', 0x00000001)
|
// CHECK-NEXT: ('st_bind', 0x00000001)
|
||||||
// CHECK-NEXT: ('st_type', 0x00000001)
|
// CHECK-NEXT: ('st_type', 0x00000001)
|
||||||
// CHECK-NEXT: ('st_other', 0x00000000)
|
// CHECK-NEXT: ('st_other', 0x00000000)
|
||||||
|
Loading…
Reference in New Issue
Block a user