6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2024-12-15 04:30:12 +00:00
Code Issues Projects Releases Wiki Activity

See comments. The live intervals were not coming out of the spiller in sorted

Browse Source 
order, causing the inactive list in the linearscan list to get unsorted, which
basically fuxored everything up severely.

These seems to fix the joiner, so with more testing I will enable it by default.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@14992 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chris Lattner 2004-07-19 05:15:10 +00:00
parent 331cb7dde1
commit 57eb15e316
1 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
lib/CodeGen/LiveIntervalAnalysis.cpp
View File

@ -185,6 +185,16 @@ bool LiveIntervals::runOnMachineFunction(MachineFunction &fn) {
return true;
}
namespace {
/// CompareIntervalStar - This is a simple comparison function for interval
/// pointers. It compares based on their starting point.
struct CompareIntervalStar {
bool operator()(LiveInterval *LHS, LiveInterval* RHS) const {
return LHS->start() < RHS->start();
}
};
}
std::vector<LiveInterval*> LiveIntervals::addIntervalsForSpills(
const LiveInterval& li,
VirtRegMap& vrm,
@ -210,7 +220,7 @@ std::vector<LiveInterval*> LiveIntervals::addIntervalsForSpills(
MachineBasicBlock::iterator mi = getInstructionFromIndex(index);
for_operand:
for (unsigned i = 0; i < mi->getNumOperands(); ++i) {
for (unsigned i = 0; i != mi->getNumOperands(); ++i) {
MachineOperand& mop = mi->getOperand(i);
if (mop.isRegister() && mop.getReg() == li.reg) {
if (MachineInstr* fmi =
@ -267,6 +277,15 @@ std::vector<LiveInterval*> LiveIntervals::addIntervalsForSpills(
}
}
// FIXME: This method MUST return intervals in sorted order. If a
// particular machine instruction both uses and defines the vreg being
// spilled (e.g., vr = vr + 1) and if the def is processed before the
// use, the list ends up not sorted.
//
// The proper way to fix this is to process all uses of the vreg before we
// process any defs. However, this would require refactoring the above
// blob of code, which I'm not feeling up to right now.
std::sort(added.begin(), added.end(), CompareIntervalStar());
return added;
}