diff --git a/lib/Transforms/Scalar/JumpThreading.cpp b/lib/Transforms/Scalar/JumpThreading.cpp index 210d6ef5a22..8b11edd891f 100644 --- a/lib/Transforms/Scalar/JumpThreading.cpp +++ b/lib/Transforms/Scalar/JumpThreading.cpp @@ -450,9 +450,11 @@ bool JumpThreading::ProcessBranchOnDuplicateCond(BasicBlock *PredBB, << "' folding condition to '" << BranchDir << "': " << *BB->getTerminator() << '\n'); ++NumFolds; + Value *OldCond = DestBI->getCondition(); DestBI->setCondition(ConstantInt::get(Type::getInt1Ty(BB->getContext()), BranchDir)); ConstantFoldTerminator(BB); + RecursivelyDeleteTriviallyDeadInstructions(OldCond); return true; } diff --git a/test/Transforms/JumpThreading/basic.ll b/test/Transforms/JumpThreading/basic.ll index 50433db152d..3d936b8f30f 100644 --- a/test/Transforms/JumpThreading/basic.ll +++ b/test/Transforms/JumpThreading/basic.ll @@ -139,3 +139,36 @@ F2: ret i32 %B } + +;; Lexically duplicated conditionals should be threaded. + + +define i32 @test6(i32 %A) { +; CHECK: @test6 + %tmp455 = icmp eq i32 %A, 42 + br i1 %tmp455, label %BB1, label %BB2 + +BB2: +; CHECK: call i32 @f1() +; CHECK-NEXT: call void @f3() +; CHECK-NEXT: ret i32 4 + call i32 @f1() + br label %BB1 + + +BB1: + %tmp459 = icmp eq i32 %A, 42 + br i1 %tmp459, label %BB3, label %BB4 + +BB3: + call i32 @f2() + ret i32 3 + +BB4: + call void @f3() + ret i32 4 +} + + + + diff --git a/test/Transforms/JumpThreading/dup-cond.ll b/test/Transforms/JumpThreading/dup-cond.ll deleted file mode 100644 index 0d14c8a54e1..00000000000 --- a/test/Transforms/JumpThreading/dup-cond.ll +++ /dev/null @@ -1,30 +0,0 @@ -; RUN: opt < %s -jump-threading -die -S | grep icmp | count 1 - -declare void @f1() -declare void @f2() -declare void @f3() - -define i32 @test(i32 %A) { - %tmp455 = icmp eq i32 %A, 42 - br i1 %tmp455, label %BB1, label %BB2 - -BB2: - call void @f1() - br label %BB1 - - -BB1: - %tmp459 = icmp eq i32 %A, 42 - br i1 %tmp459, label %BB3, label %BB4 - -BB3: - call void @f2() - ret i32 3 - -BB4: - call void @f3() - ret i32 4 -} - - -