6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-01-14 16:33:28 +00:00
Code Issues Projects Releases Wiki Activity

[objc-arc-opts] Now that PtrState.RRI is encapsulated in PtrState, make PtrState.RRI private and delete the TODO.

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@184587 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Michael Gottesman 2013-06-21 19:44:30 +00:00
parent 72507101f7
commit 5a18572320
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/Transforms/ObjCARC/ObjCARCOpts.cpp
View File

@ -518,12 +518,10 @@ namespace {
/// The current position in the sequence. /// The current position in the sequence.
Sequence Seq : 8; Sequence Seq : 8;
public:
/// Unidirectional information about the current sequence. /// Unidirectional information about the current sequence.
///
/// TODO: Encapsulate this better.
RRInfo RRI; RRInfo RRI;
public:
PtrState() : KnownPositiveRefCount(false), Partial(false), PtrState() : KnownPositiveRefCount(false), Partial(false),
Seq(S_None) {} Seq(S_None) {}
@ -615,6 +613,10 @@ namespace {
bool HasReverseInsertPts() const { bool HasReverseInsertPts() const {
return !RRI.ReverseInsertPts.empty(); return !RRI.ReverseInsertPts.empty();
} }
const RRInfo &GetRRInfo() const {
return RRI;
}
}; };
} }
@ -1991,7 +1993,7 @@ ObjCARCOpt::VisitInstructionBottomUp(Instruction *Inst,
// Don't do retain+release tracking for IC_RetainRV, because it's // Don't do retain+release tracking for IC_RetainRV, because it's
// better to let it remain as the first instruction after a call. // better to let it remain as the first instruction after a call.
if (Class != IC_RetainRV) if (Class != IC_RetainRV)
Retains[Inst] = S.RRI; Retains[Inst] = S.GetRRInfo();
S.ClearSequenceProgress(); S.ClearSequenceProgress();
break; break;
case S_None: case S_None:
@ -2245,7 +2247,7 @@ ObjCARCOpt::VisitInstructionTopDown(Instruction *Inst,
case S_Use: case S_Use:
S.SetReleaseMetadata(ReleaseMetadata); S.SetReleaseMetadata(ReleaseMetadata);
S.SetTailCallRelease(cast<CallInst>(Inst)->isTailCall()); S.SetTailCallRelease(cast<CallInst>(Inst)->isTailCall());
Releases[Inst] = S.RRI; Releases[Inst] = S.GetRRInfo();
ANNOTATE_TOPDOWN(Inst, Arg, S.GetSeq(), S_None); ANNOTATE_TOPDOWN(Inst, Arg, S.GetSeq(), S_None);
S.ClearSequenceProgress(); S.ClearSequenceProgress();
break; break;