From 5a39b2e8067450839a1a041a26e2f9d8dd07f40a Mon Sep 17 00:00:00 2001 From: Devang Patel Date: Wed, 8 Nov 2006 10:29:57 +0000 Subject: [PATCH] Split PassManager_New into PassManager_New and PassManagerImpl_New. PassManagerImpl_New implements the pass manager. PassManager_New is the public interface. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@31546 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/PassManager.h | 20 ++++-------- lib/VMCore/PassManager.cpp | 65 +++++++++++++++++++++++++++++++++++--- 2 files changed, 67 insertions(+), 18 deletions(-) diff --git a/include/llvm/PassManager.h b/include/llvm/PassManager.h index 31ce3daae4f..927ea9f785b 100644 --- a/include/llvm/PassManager.h +++ b/include/llvm/PassManager.h @@ -89,6 +89,7 @@ public: }; class ModulePassManager_New; +class PassManagerImpl_New; /// PassManagerAnalysisHelper helps pass manager analysis required by /// the managed passes. It provides methods to add/remove analysis @@ -127,6 +128,8 @@ class PassManager_New : public Pass, public: + PassManager_New(); + /// add - Add a pass to the queue of passes to run. This passes ownership of /// the Pass to the PassManager. When the PassManager is destroyed, the pass /// will be destroyed as well, so there is no need to delete the pass. This @@ -138,22 +141,11 @@ public: bool run(Module &M); private: - - /// Add a pass into a passmanager queue. This is used by schedulePasses - bool addPass(Pass *p); - /// Schedule all passes collected in pass queue using add(). Add all the - /// schedule passes into various manager's queue using addPass(). - void schedulePasses(); + /// PassManagerImpl_New is the actual class. PassManager_New is just the + /// wraper to publish simple pass manager interface + PassManagerImpl_New *PM; - // Collection of pass managers - std::vector PassManagers; - - // Collection of pass that are not yet scheduled - std::vector PassVector; - - // Active Pass Manager - ModulePassManager_New *activeManager; }; } // End llvm namespace diff --git a/lib/VMCore/PassManager.cpp b/lib/VMCore/PassManager.cpp index 2592c4e907a..5d5b67baa53 100644 --- a/lib/VMCore/PassManager.cpp +++ b/lib/VMCore/PassManager.cpp @@ -100,6 +100,41 @@ private: FunctionPassManager_New *activeFunctionPassManager; }; +/// PassManager_New manages ModulePassManagers +class PassManagerImpl_New : public Pass, + public PassManagerAnalysisHelper { + +public: + + /// add - Add a pass to the queue of passes to run. This passes ownership of + /// the Pass to the PassManager. When the PassManager is destroyed, the pass + /// will be destroyed as well, so there is no need to delete the pass. This + /// implies that all passes MUST be allocated with 'new'. + void add(Pass *P); + + /// run - Execute all of the passes scheduled for execution. Keep track of + /// whether any of the passes modifies the module, and if so, return true. + bool run(Module &M); + +private: + + /// Add a pass into a passmanager queue. This is used by schedulePasses + bool addPass(Pass *p); + + /// Schedule all passes collected in pass queue using add(). Add all the + /// schedule passes into various manager's queue using addPass(). + void schedulePasses(); + + // Collection of pass managers + std::vector PassManagers; + + // Collection of pass that are not yet scheduled + std::vector PassVector; + + // Active Pass Manager + ModulePassManager_New *activeManager; +}; + } // End of llvm namespace // PassManagerAnalysisHelper implementation @@ -304,13 +339,13 @@ ModulePassManager_New::runOnModule(Module &M) { /// Schedule all passes from the queue by adding them in their /// respective manager's queue. void -PassManager_New::schedulePasses() { +PassManagerImpl_New::schedulePasses() { /* TODO */ } /// Add pass P to the queue of passes to run. void -PassManager_New::add(Pass *P) { +PassManagerImpl_New::add(Pass *P) { /* TODO */ } @@ -318,7 +353,7 @@ PassManager_New::add(Pass *P) { /// Add P into active pass manager or use new module pass manager to /// manage it. bool -PassManager_New::addPass(Pass *P) { +PassManagerImpl_New::addPass(Pass *P) { if (!activeManager) { activeManager = new ModulePassManager_New(); @@ -331,7 +366,7 @@ PassManager_New::addPass(Pass *P) { /// run - Execute all of the passes scheduled for execution. Keep track of /// whether any of the passes modifies the module, and if so, return true. bool -PassManager_New::run(Module &M) { +PassManagerImpl_New::run(Module &M) { schedulePasses(); bool Changed = false; @@ -342,3 +377,25 @@ PassManager_New::run(Module &M) { } return Changed; } + +/// Create new pass manager +PassManager_New::PassManager_New() { + PM = new PassManagerImpl_New(); +} + +/// add - Add a pass to the queue of passes to run. This passes ownership of +/// the Pass to the PassManager. When the PassManager is destroyed, the pass +/// will be destroyed as well, so there is no need to delete the pass. This +/// implies that all passes MUST be allocated with 'new'. +void +PassManager_New::add(Pass *P) { + PM->add(P); +} + +/// run - Execute all of the passes scheduled for execution. Keep track of +/// whether any of the passes modifies the module, and if so, return true. +bool +PassManager_New::run(Module &M) { + return PM->run(M); +} +