From 5a45bf1b48cd3d23faa3dfc27b8866bb536c4b9e Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Tue, 9 Dec 2008 22:45:32 +0000 Subject: [PATCH] loosen up an assertion that isn't valid when called from invalidateCachedPointerInfo. Thanks to Bill for sending me a testcase. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@60805 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Analysis/MemoryDependenceAnalysis.cpp | 2 +- test/Transforms/GVN/2008-12-09-SelfRemove.ll | 26 ++++++++++++++++++++ 2 files changed, 27 insertions(+), 1 deletion(-) create mode 100644 test/Transforms/GVN/2008-12-09-SelfRemove.ll diff --git a/lib/Analysis/MemoryDependenceAnalysis.cpp b/lib/Analysis/MemoryDependenceAnalysis.cpp index 0b185b1c7cf..dbaea11ae4a 100644 --- a/lib/Analysis/MemoryDependenceAnalysis.cpp +++ b/lib/Analysis/MemoryDependenceAnalysis.cpp @@ -687,7 +687,7 @@ RemoveCachedNonLocalPointerDependencies(ValueIsLoadPair P) { for (unsigned i = 0, e = PInfo.size(); i != e; ++i) { Instruction *Target = PInfo[i].second.getInst(); if (Target == 0) continue; // Ignore non-local dep results. - assert(Target->getParent() == PInfo[i].first && Target != P.getPointer()); + assert(Target->getParent() == PInfo[i].first); // Eliminating the dirty entry from 'Cache', so update the reverse info. RemoveFromReverseMap(ReverseNonLocalPtrDeps, Target, P.getOpaqueValue()); diff --git a/test/Transforms/GVN/2008-12-09-SelfRemove.ll b/test/Transforms/GVN/2008-12-09-SelfRemove.ll new file mode 100644 index 00000000000..48ce8f6ff46 --- /dev/null +++ b/test/Transforms/GVN/2008-12-09-SelfRemove.ll @@ -0,0 +1,26 @@ +; RUN: llvm-as < %s | opt -gvn | llvm-dis | grep getelementptr | count 1 + +target datalayout = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:64:64-v128:128:128-a0:0:64-f80:128:128" +target triple = "i386-apple-darwin9.5" + %struct.anon = type { i8*, i32 } + %struct.d_print_info = type { i32, i8*, i32, i32, %struct.d_print_template*, %struct.d_print_mod*, i32 } + %struct.d_print_mod = type { %struct.d_print_mod*, %struct.demangle_component*, i32, %struct.d_print_template* } + %struct.d_print_template = type { %struct.d_print_template*, %struct.demangle_component* } + %struct.demangle_component = type { i32, { %struct.anon } } + +define void @d_print_mod_list(%struct.d_print_info* %dpi, %struct.d_print_mod* %mods, i32 %suffix) nounwind { +entry: + %0 = getelementptr %struct.d_print_info* %dpi, i32 0, i32 1 ; [#uses=1] + br i1 false, label %return, label %bb + +bb: ; preds = %entry + %1 = load i8** %0, align 4 ; [#uses=0] + %2 = getelementptr %struct.d_print_info* %dpi, i32 0, i32 1 ; [#uses=0] + br label %bb21 + +bb21: ; preds = %bb21, %bb + br label %bb21 + +return: ; preds = %entry + ret void +}