Add comments for missed opportunities.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@100610 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Evan Cheng 2010-04-07 06:00:33 +00:00
parent 348856e56a
commit 5b463905be

View File

@ -247,6 +247,8 @@ void MachineLICM::HoistRegionPostRA(MachineDomTreeNode *N) {
if (!CurLoop->contains(BB)) if (!CurLoop->contains(BB))
continue; continue;
// Conservatively treat live-in's as an external def. // Conservatively treat live-in's as an external def.
// FIXME: That means a reload that's reused into a fallthrough block
// will not be LICM'ed.
for (MachineBasicBlock::const_livein_iterator I = BB->livein_begin(), for (MachineBasicBlock::const_livein_iterator I = BB->livein_begin(),
E = BB->livein_end(); I != E; ++I) { E = BB->livein_end(); I != E; ++I) {
unsigned Reg = *I; unsigned Reg = *I;
@ -282,7 +284,8 @@ void MachineLICM::HoistRegionPostRA(MachineDomTreeNode *N) {
} }
} }
// FIXME: Only consider reloads for now. // FIXME: Only consider reloads for now. We should be able to handle
// remat which does not have register operands.
bool SkipCheck = false; bool SkipCheck = false;
int FI; int FI;
if (SeenDef && !RuledOut) { if (SeenDef && !RuledOut) {