From 5fb107287fd8d35b8fc39aa3e6b084fb2871a8ff Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Sat, 10 Oct 2009 22:41:58 +0000 Subject: [PATCH] rename GetValueInBlock -> GetValueAtEndOfBlock to better reflect what it does. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@83740 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/Transforms/Utils/SSAUpdater.h | 8 ++++---- lib/Transforms/Utils/SSAUpdater.cpp | 22 +++++++++++----------- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/include/llvm/Transforms/Utils/SSAUpdater.h b/include/llvm/Transforms/Utils/SSAUpdater.h index 5e11984bf39..2897af93c47 100644 --- a/include/llvm/Transforms/Utils/SSAUpdater.h +++ b/include/llvm/Transforms/Utils/SSAUpdater.h @@ -52,16 +52,16 @@ public: /// specified block with the specified value. void AddAvailableValue(BasicBlock *BB, Value *V); - /// GetValueInBlock - Construct SSA form, materializing a value in the - /// specified block. - Value *GetValueInBlock(BasicBlock *BB); + /// GetValueAtEndOfBlock - Construct SSA form, materializing a value that is + /// live at the end of the specified block. + Value *GetValueAtEndOfBlock(BasicBlock *BB); /// RewriteUse - Rewrite a use of the symbolic value. This handles PHI nodes, /// which use their value in the corresponding predecessor. void RewriteUse(Use &U); private: - Value *GetValueInBlockInternal(BasicBlock *BB); + Value *GetValueAtEndOfBlockInternal(BasicBlock *BB); void operator=(const SSAUpdater&); // DO NOT IMPLEMENT SSAUpdater(const SSAUpdater&); // DO NOT IMPLEMENT }; diff --git a/lib/Transforms/Utils/SSAUpdater.cpp b/lib/Transforms/Utils/SSAUpdater.cpp index 0baa5a8ca62..be9d147409f 100644 --- a/lib/Transforms/Utils/SSAUpdater.cpp +++ b/lib/Transforms/Utils/SSAUpdater.cpp @@ -64,11 +64,11 @@ void SSAUpdater::AddAvailableValue(BasicBlock *BB, Value *V) { getAvailableVals(AV)[BB] = V; } -/// GetValueInBlock - Construct SSA form, materializing a value in the +/// GetValueAtEndOfBlock - Construct SSA form, materializing a value in the /// specified block. -Value *SSAUpdater::GetValueInBlock(BasicBlock *BB) { +Value *SSAUpdater::GetValueAtEndOfBlock(BasicBlock *BB) { assert(getIncomingPredInfo(IPI).empty() && "Unexpected Internal State"); - Value *Res = GetValueInBlockInternal(BB); + Value *Res = GetValueAtEndOfBlockInternal(BB); assert(getIncomingPredInfo(IPI).empty() && "Unexpected Internal State"); return Res; } @@ -81,16 +81,16 @@ void SSAUpdater::RewriteUse(Use &U) { if (PHINode *UserPN = dyn_cast(User)) UseBB = UserPN->getIncomingBlock(U); - U.set(GetValueInBlock(UseBB)); + U.set(GetValueAtEndOfBlock(UseBB)); } -/// GetValueInBlock - Check to see if AvailableVals has an entry for the -/// specified BB and if so, return it. If not, construct SSA form by walking -/// predecessors inserting PHI nodes as needed until we get to a block where the -/// value is available. +/// GetValueAtEndOfBlockInternal - Check to see if AvailableVals has an entry +/// for the specified BB and if so, return it. If not, construct SSA form by +/// walking predecessors inserting PHI nodes as needed until we get to a block +/// where the value is available. /// -Value *SSAUpdater::GetValueInBlockInternal(BasicBlock *BB) { +Value *SSAUpdater::GetValueAtEndOfBlockInternal(BasicBlock *BB) { AvailableValsTy &AvailableVals = getAvailableVals(AV); // Query AvailableVals by doing an insertion of null. @@ -138,7 +138,7 @@ Value *SSAUpdater::GetValueInBlockInternal(BasicBlock *BB) { if (PHINode *SomePhi = dyn_cast(BB->begin())) { for (unsigned i = 0, e = SomePhi->getNumIncomingValues(); i != e; ++i) { BasicBlock *PredBB = SomePhi->getIncomingBlock(i); - Value *PredVal = GetValueInBlockInternal(PredBB); + Value *PredVal = GetValueAtEndOfBlockInternal(PredBB); IncomingPredInfo.push_back(std::make_pair(PredBB, PredVal)); // Compute SingularValue. @@ -151,7 +151,7 @@ Value *SSAUpdater::GetValueInBlockInternal(BasicBlock *BB) { bool isFirstPred = true; for (pred_iterator PI = pred_begin(BB), E = pred_end(BB); PI != E; ++PI) { BasicBlock *PredBB = *PI; - Value *PredVal = GetValueInBlockInternal(PredBB); + Value *PredVal = GetValueAtEndOfBlockInternal(PredBB); IncomingPredInfo.push_back(std::make_pair(PredBB, PredVal)); // Compute SingularValue.