6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-07-02 19:24:25 +00:00
Code Issues Projects Releases Wiki Activity

Make use of getUMinFromMismatchedTypes when computing backedge-taken

Browse Source 
counts for loops with multiple exits, replacing more conservative code
which only handled constants. This is derived from a patch by
Nick Lewycky.

This also fixes llc aborts in ClamAV and others, as
getUMinFromMismatchedTypes takes care of balancing the types before
working with them.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@73884 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Dan Gohman
2009-06-22 15:09:28 +00:00
parent c9759e80f4
commit 60e9b0708a
1 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
lib/Analysis/ScalarEvolution.cpp
View File

@ -2958,18 +2958,18 @@ ScalarEvolution::ComputeBackedgeTakenCountFromExitCond(const Loop *L,
if (L->contains(TBB)) { if (L->contains(TBB)) {
// Both conditions must be true for the loop to continue executing. // Both conditions must be true for the loop to continue executing.
// Choose the less conservative count. // Choose the less conservative count.
// TODO: Take the minimum of the exact counts. if (BTI0.Exact == CouldNotCompute)
if (BTI0.Exact == BTI1.Exact) BECount = BTI1.Exact;
else if (BTI1.Exact == CouldNotCompute)
BECount = BTI0.Exact; BECount = BTI0.Exact;
// TODO: Take the minimum of the maximum counts. else
BECount = getUMinFromMismatchedTypes(BTI0.Exact, BTI1.Exact);
if (BTI0.Max == CouldNotCompute) if (BTI0.Max == CouldNotCompute)
MaxBECount = BTI1.Max; MaxBECount = BTI1.Max;
else if (BTI1.Max == CouldNotCompute) else if (BTI1.Max == CouldNotCompute)
MaxBECount = BTI0.Max; MaxBECount = BTI0.Max;
else if (const SCEVConstant *C0 = dyn_cast<SCEVConstant>(BTI0.Max)) else
if (const SCEVConstant *C1 = dyn_cast<SCEVConstant>(BTI1.Max)) MaxBECount = getUMinFromMismatchedTypes(BTI0.Max, BTI1.Max);
MaxBECount = getConstant(APIntOps::umin(C0->getValue()->getValue(),
C1->getValue()->getValue()));
} else { } else {
// Both conditions must be true for the loop to exit. // Both conditions must be true for the loop to exit.
assert(L->contains(FBB) && "Loop block has no successor in loop!"); assert(L->contains(FBB) && "Loop block has no successor in loop!");
@ -2992,18 +2992,18 @@ ScalarEvolution::ComputeBackedgeTakenCountFromExitCond(const Loop *L,
if (L->contains(FBB)) { if (L->contains(FBB)) {
// Both conditions must be false for the loop to continue executing. // Both conditions must be false for the loop to continue executing.
// Choose the less conservative count. // Choose the less conservative count.
// TODO: Take the minimum of the exact counts. if (BTI0.Exact == CouldNotCompute)
if (BTI0.Exact == BTI1.Exact) BECount = BTI1.Exact;
else if (BTI1.Exact == CouldNotCompute)
BECount = BTI0.Exact; BECount = BTI0.Exact;
// TODO: Take the minimum of the maximum counts. else
BECount = getUMinFromMismatchedTypes(BTI0.Exact, BTI1.Exact);
if (BTI0.Max == CouldNotCompute) if (BTI0.Max == CouldNotCompute)
MaxBECount = BTI1.Max; MaxBECount = BTI1.Max;
else if (BTI1.Max == CouldNotCompute) else if (BTI1.Max == CouldNotCompute)
MaxBECount = BTI0.Max; MaxBECount = BTI0.Max;
else if (const SCEVConstant *C0 = dyn_cast<SCEVConstant>(BTI0.Max)) else
if (const SCEVConstant *C1 = dyn_cast<SCEVConstant>(BTI1.Max)) MaxBECount = getUMinFromMismatchedTypes(BTI0.Max, BTI1.Max);
MaxBECount = getConstant(APIntOps::umin(C0->getValue()->getValue(),
C1->getValue()->getValue()));
} else { } else {
// Both conditions must be false for the loop to exit. // Both conditions must be false for the loop to exit.
assert(L->contains(TBB) && "Loop block has no successor in loop!"); assert(L->contains(TBB) && "Loop block has no successor in loop!");