DWARF parser: propery handle DW_FORM_ref_sig8 and fix Windows build.

Based on D2050 by Timur Iskhodzhanov.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@193619 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Alexey Samsonov 2013-10-29 16:32:19 +00:00
parent a300b1cc29
commit 636a5cb8de
2 changed files with 42 additions and 43 deletions

View File

@ -21,15 +21,14 @@ using namespace llvm;
using namespace dwarf;
namespace {
template <uint8_t AddrSize, uint8_t RefAddrSize> struct FixedFormSizes {
// FIXME: do we need a template here? Will a stack-allocated struct with
// an initializer in getFixedFormSizes() work just fine?
static const uint8_t sizes[27];
};
uint8_t getRefAddrSize(uint8_t AddrSize, uint16_t Version) {
// FIXME: Support DWARF64.
return (Version == 2) ? AddrSize : 4;
}
template <uint8_t AddrSize, uint8_t RefAddrSize>
const uint8_t FixedFormSizes<AddrSize, RefAddrSize>::sizes[] = {
ArrayRef<uint8_t> makeFixedFormSizesArrayRef() {
static const uint8_t sizes[] = {
0, // 0x00 unused
AddrSize, // 0x01 DW_FORM_addr
0, // 0x02 unused
@ -56,25 +55,22 @@ const uint8_t FixedFormSizes<AddrSize, RefAddrSize>::sizes[] = {
4, // 0x17 DW_FORM_sec_offset
0, // 0x18 DW_FORM_exprloc
0, // 0x19 DW_FORM_flag_present
8, // 0x20 DW_FORM_ref_sig8
};
static uint8_t getRefAddrSize(uint8_t AddrSize, uint16_t Version) {
// FIXME: Support DWARF64.
return (Version == 2) ? AddrSize : 4;
return makeArrayRef(sizes);
}
}
ArrayRef<uint8_t> DWARFFormValue::getFixedFormSizes(uint8_t AddrSize,
uint16_t Version) {
uint8_t RefAddrSize = getRefAddrSize(AddrSize, Version);
if (AddrSize == 4 && RefAddrSize == 4)
return makeArrayRef(FixedFormSizes<4, 4>::sizes);
return makeFixedFormSizesArrayRef<4, 4>();
if (AddrSize == 4 && RefAddrSize == 8)
return makeArrayRef(FixedFormSizes<4, 8>::sizes);
return makeFixedFormSizesArrayRef<4, 8>();
if (AddrSize == 8 && RefAddrSize == 4)
return makeArrayRef(FixedFormSizes<8, 4>::sizes);
return makeFixedFormSizesArrayRef<8, 4>();
if (AddrSize == 8 && RefAddrSize == 8)
return makeArrayRef(FixedFormSizes<8, 8>::sizes);
return makeFixedFormSizesArrayRef<8, 8>();
return None;
}
@ -107,7 +103,6 @@ static const DWARFFormValue::FormClass DWARF4FormClasses[] = {
DWARFFormValue::FC_SectionOffset, // 0x17 DW_FORM_sec_offset
DWARFFormValue::FC_Exprloc, // 0x18 DW_FORM_exprloc
DWARFFormValue::FC_Flag, // 0x19 DW_FORM_flag_present
DWARFFormValue::FC_Reference, // 0x20 DW_FORM_ref_sig8
};
bool DWARFFormValue::isFormClass(DWARFFormValue::FormClass FC) const {
@ -115,6 +110,9 @@ bool DWARFFormValue::isFormClass(DWARFFormValue::FormClass FC) const {
if (Form < ArrayRef<FormClass>(DWARF4FormClasses).size() &&
DWARF4FormClasses[Form] == FC)
return true;
// Check DW_FORM_ref_sig8 from DWARF4.
if (Form == DW_FORM_ref_sig8)
return (FC == FC_Reference);
// Check for some DWARF5 forms.
if (Form == DW_FORM_GNU_addr_index)
return (FC == FC_Address);

View File

@ -43,6 +43,7 @@ TEST(DWARFFormValue, FormClass) {
EXPECT_TRUE(isFormClass(DW_FORM_GNU_addr_index, DWARFFormValue::FC_Address));
EXPECT_FALSE(isFormClass(DW_FORM_ref_addr, DWARFFormValue::FC_Address));
EXPECT_TRUE(isFormClass(DW_FORM_ref_addr, DWARFFormValue::FC_Reference));
EXPECT_TRUE(isFormClass(DW_FORM_ref_sig8, DWARFFormValue::FC_Reference));
}
} // end anonymous namespace