mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2024-08-21 18:29:46 +00:00
Assert that ValueHandleBase::ValueIsRAUWd doesn't change the tracked Value type.
This invariant is enforced in Value::replaceAllUsesWith, thus it seems logical to apply it also to ValueHandles. This commit fixes InstCombine to not trigger the assertion during the removal of constant bitcasts in call instructions. Differential Revision: http://reviews.llvm.org/D5828 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@220468 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
parent
54d6b1b71e
commit
648728d4e4
@ -773,6 +773,8 @@ void ValueHandleBase::ValueIsDeleted(Value *V) {
|
||||
void ValueHandleBase::ValueIsRAUWd(Value *Old, Value *New) {
|
||||
assert(Old->HasValueHandle &&"Should only be called if ValueHandles present");
|
||||
assert(Old != New && "Changing value into itself!");
|
||||
assert(Old->getType() == New->getType() &&
|
||||
"replaceAllUses of value with new value of different type!");
|
||||
|
||||
// Get the linked list base, which is guaranteed to exist since the
|
||||
// HasValueHandle flag is set.
|
||||
|
@ -1370,7 +1370,7 @@ bool InstCombiner::transformConstExprCastCall(CallSite CS) {
|
||||
if (!Caller->use_empty() &&
|
||||
// void -> non-void is handled specially
|
||||
!NewRetTy->isVoidTy())
|
||||
return false; // Cannot transform this return value.
|
||||
return false; // Cannot transform this return value.
|
||||
}
|
||||
|
||||
if (!CallerPAL.isEmpty() && !Caller->use_empty()) {
|
||||
@ -1589,8 +1589,14 @@ bool InstCombiner::transformConstExprCastCall(CallSite CS) {
|
||||
|
||||
if (!Caller->use_empty())
|
||||
ReplaceInstUsesWith(*Caller, NV);
|
||||
else if (Caller->hasValueHandle())
|
||||
ValueHandleBase::ValueIsRAUWd(Caller, NV);
|
||||
else if (Caller->hasValueHandle()) {
|
||||
if (OldRetTy == NV->getType())
|
||||
ValueHandleBase::ValueIsRAUWd(Caller, NV);
|
||||
else
|
||||
// We cannot call ValueIsRAUWd with a different type, and the
|
||||
// actual tracked value will disappear.
|
||||
ValueHandleBase::ValueIsDeleted(Caller);
|
||||
}
|
||||
|
||||
EraseInstFromFunction(*Caller);
|
||||
return true;
|
||||
|
Loading…
Reference in New Issue
Block a user