Checking for "zero operands" during the "CanHoistInst()" method isn't necessary

because those with side effects will be caught by other checks in here.

Also, simplify the check for a BB in a sub loop.



git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@44871 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Bill Wendling 2007-12-11 18:45:11 +00:00
parent 6e041c2015
commit 650b0527a4

View File

@ -99,13 +99,7 @@ namespace {
/// ///
bool IsInSubLoop(MachineBasicBlock *BB) { bool IsInSubLoop(MachineBasicBlock *BB) {
assert(CurLoop->contains(BB) && "Only valid if BB is IN the loop"); assert(CurLoop->contains(BB) && "Only valid if BB is IN the loop");
return LI->getLoopFor(BB) != CurLoop;
for (MachineLoop::iterator
I = CurLoop->begin(), E = CurLoop->end(); I != E; ++I)
if ((*I)->contains(BB))
return true; // A subloop actually contains this block!
return false;
} }
/// CanHoistInst - Checks that this instructions is one that can be hoisted /// CanHoistInst - Checks that this instructions is one that can be hoisted
@ -115,9 +109,8 @@ namespace {
bool CanHoistInst(MachineInstr &I) const { bool CanHoistInst(MachineInstr &I) const {
const TargetInstrDescriptor *TID = I.getInstrDescriptor(); const TargetInstrDescriptor *TID = I.getInstrDescriptor();
// Don't hoist if this instruction implicitly reads physical registers or // Don't hoist if this instruction implicitly reads physical registers.
// doesn't take any operands. if (TID->ImplicitUses) return false;
if (TID->ImplicitUses || !I.getNumOperands()) return false;
MachineOpCode Opcode = TID->Opcode; MachineOpCode Opcode = TID->Opcode;
return TII->isTriviallyReMaterializable(&I) && return TII->isTriviallyReMaterializable(&I) &&
@ -142,7 +135,7 @@ namespace {
/// FindPredecessors - Get all of the predecessors of the loop that are not /// FindPredecessors - Get all of the predecessors of the loop that are not
/// back-edges. /// back-edges.
/// ///
void FindPredecessors(std::vector<MachineBasicBlock*> &Preds){ void FindPredecessors(std::vector<MachineBasicBlock*> &Preds) {
const MachineBasicBlock *Header = CurLoop->getHeader(); const MachineBasicBlock *Header = CurLoop->getHeader();
for (MachineBasicBlock::const_pred_iterator for (MachineBasicBlock::const_pred_iterator