diff --git a/docs/LangRef.rst b/docs/LangRef.rst index 397d5fe3756..0996820f724 100644 --- a/docs/LangRef.rst +++ b/docs/LangRef.rst @@ -834,6 +834,11 @@ Named metadata is a collection of metadata. :ref:`Metadata nodes ` (but not metadata strings) are the only valid operands for a named metadata. +#. Named metadata are represented as a string of characters with the + metadata prefix. The rules for metadata names are the same as for + identifiers, but quoted names are not allowed. ``"\xx"`` type escapes + are still valid, which allows any character to be part of a name. + Syntax:: ; Some unnamed metadata nodes, which are referenced by the named metadata. diff --git a/lib/IR/AsmWriter.cpp b/lib/IR/AsmWriter.cpp index 86bcd658185..715aad8b03a 100644 --- a/lib/IR/AsmWriter.cpp +++ b/lib/IR/AsmWriter.cpp @@ -2215,9 +2215,8 @@ void AssemblyWriter::printModule(const Module *M) { } } -void AssemblyWriter::printNamedMDNode(const NamedMDNode *NMD) { - Out << '!'; - StringRef Name = NMD->getName(); +static void printMetadataIdentifier(StringRef Name, + formatted_raw_ostream &Out) { if (Name.empty()) { Out << " "; } else { @@ -2235,6 +2234,11 @@ void AssemblyWriter::printNamedMDNode(const NamedMDNode *NMD) { Out << '\\' << hexdigit(C >> 4) << hexdigit(C & 0x0F); } } +} + +void AssemblyWriter::printNamedMDNode(const NamedMDNode *NMD) { + Out << '!'; + printMetadataIdentifier(NMD->getName(), Out); Out << " = !{"; for (unsigned i = 0, e = NMD->getNumOperands(); i != e; ++i) { if (i) @@ -3006,9 +3010,10 @@ void AssemblyWriter::printMetadataAttachments( for (const auto &I : MDs) { unsigned Kind = I.first; Out << Separator; - if (Kind < MDNames.size()) - Out << "!" << MDNames[Kind]; - else + if (Kind < MDNames.size()) { + Out << "!"; + printMetadataIdentifier(MDNames[Kind], Out); + } else Out << "!"; Out << ' '; WriteAsOperandInternal(Out, I.second, &TypePrinter, &Machine, TheModule); diff --git a/lib/IR/LLVMContext.cpp b/lib/IR/LLVMContext.cpp index e8bf442b3e1..7bcd829f9f5 100644 --- a/lib/IR/LLVMContext.cpp +++ b/lib/IR/LLVMContext.cpp @@ -242,9 +242,6 @@ void LLVMContext::emitError(unsigned LocCookie, const Twine &ErrorStr) { /// Return a unique non-zero ID for the specified metadata kind. unsigned LLVMContext::getMDKindID(StringRef Name) const { - assert(!std::isdigit(Name.front()) && - "Named metadata may not start with a digit"); - // If this is new, assign it its ID. return pImpl->CustomMDKindNames.insert( std::make_pair( diff --git a/test/Assembler/metadata.ll b/test/Assembler/metadata.ll index 8d5e91fb332..052ac1b5097 100644 --- a/test/Assembler/metadata.ll +++ b/test/Assembler/metadata.ll @@ -22,6 +22,13 @@ define void @test3() !bar !3 { unreachable, !bar !4 } +; CHECK-LABEL: define void @test_attachment_name() { +; CHECK: unreachable, !\342abc !4 +define void @test_attachment_name() { + ;; Escape the first character when printing text IR, since it's a digit + unreachable, !\34\32abc !4 +} + !0 = !DILocation(line: 662302, column: 26, scope: !1) !1 = !DISubprogram(name: "foo") !2 = distinct !{}