Get rid of shifts by zero in most cases.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18931 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Brian Gaeke 2004-12-14 08:21:02 +00:00
parent 626e38e481
commit 6b260e2638
4 changed files with 12 additions and 24 deletions

View File

@ -55,13 +55,6 @@ To-do
* support casting 64-bit integers to FP types (fhourstones needs this)
* support FP rem (call fmod)
* Eliminate srl/sll by zero bits like this:
sll %l0, 0, %l0
srl %l0, 0, %o0
We think these are only used by V9 to clear off the top 32 bits of a reg,
so they are not needed.
* Keep the address of the constant pool in a register instead of forming its
address all of the time.

View File

@ -71,7 +71,8 @@ namespace {
unsigned emitIntegerCast (MachineBasicBlock *BB,
MachineBasicBlock::iterator IP,
const Type *oldTy, unsigned SrcReg,
const Type *newTy, unsigned DestReg);
const Type *newTy, unsigned DestReg,
bool castToLong = false);
void emitFPToIntegerCast (MachineBasicBlock *BB,
MachineBasicBlock::iterator IP, const Type *oldTy,
unsigned SrcReg, const Type *newTy,
@ -606,15 +607,15 @@ void V8ISel::visitCastInst(CastInst &I) {
unsigned V8ISel::emitIntegerCast (MachineBasicBlock *BB,
MachineBasicBlock::iterator IP, const Type *oldTy,
unsigned SrcReg, const Type *newTy,
unsigned DestReg) {
if (oldTy == newTy) {
unsigned DestReg, bool castToLong) {
unsigned shiftWidth = 32 - (8 * TM.getTargetData ().getTypeSize (newTy));
if (oldTy == newTy || (!castToLong && shiftWidth == 0)) {
// No-op cast - just emit a copy; assume the reg. allocator will zap it.
BuildMI (*BB, IP, V8::ORrr, 2, DestReg).addReg (V8::G0).addReg(SrcReg);
return SrcReg;
}
// Emit left-shift, then right-shift to sign- or zero-extend.
unsigned TmpReg = makeAnotherReg (newTy);
unsigned shiftWidth = 32 - (8 * TM.getTargetData ().getTypeSize (newTy));
BuildMI (*BB, IP, V8::SLLri, 2, TmpReg).addZImm (shiftWidth).addReg(SrcReg);
if (newTy->isSigned ()) { // sign-extend with SRA
BuildMI(*BB, IP, V8::SRAri, 2, DestReg).addZImm (shiftWidth).addReg(TmpReg);
@ -739,7 +740,7 @@ void V8ISel::emitCastOperation(MachineBasicBlock *BB,
const Type *OldHalfTy = oldTy->isSigned() ? Type::IntTy : Type::UIntTy;
const Type *NewHalfTy = newTy->isSigned() ? Type::IntTy : Type::UIntTy;
unsigned TempReg = emitIntegerCast (BB, IP, OldHalfTy, SrcReg,
NewHalfTy, DestReg+1);
NewHalfTy, DestReg+1, true);
if (newTy->isSigned ()) {
BuildMI (*BB, IP, V8::SRAri, 2, DestReg).addReg (TempReg)
.addZImm (31);

View File

@ -55,13 +55,6 @@ To-do
* support casting 64-bit integers to FP types (fhourstones needs this)
* support FP rem (call fmod)
* Eliminate srl/sll by zero bits like this:
sll %l0, 0, %l0
srl %l0, 0, %o0
We think these are only used by V9 to clear off the top 32 bits of a reg,
so they are not needed.
* Keep the address of the constant pool in a register instead of forming its
address all of the time.

View File

@ -71,7 +71,8 @@ namespace {
unsigned emitIntegerCast (MachineBasicBlock *BB,
MachineBasicBlock::iterator IP,
const Type *oldTy, unsigned SrcReg,
const Type *newTy, unsigned DestReg);
const Type *newTy, unsigned DestReg,
bool castToLong = false);
void emitFPToIntegerCast (MachineBasicBlock *BB,
MachineBasicBlock::iterator IP, const Type *oldTy,
unsigned SrcReg, const Type *newTy,
@ -606,15 +607,15 @@ void V8ISel::visitCastInst(CastInst &I) {
unsigned V8ISel::emitIntegerCast (MachineBasicBlock *BB,
MachineBasicBlock::iterator IP, const Type *oldTy,
unsigned SrcReg, const Type *newTy,
unsigned DestReg) {
if (oldTy == newTy) {
unsigned DestReg, bool castToLong) {
unsigned shiftWidth = 32 - (8 * TM.getTargetData ().getTypeSize (newTy));
if (oldTy == newTy || (!castToLong && shiftWidth == 0)) {
// No-op cast - just emit a copy; assume the reg. allocator will zap it.
BuildMI (*BB, IP, V8::ORrr, 2, DestReg).addReg (V8::G0).addReg(SrcReg);
return SrcReg;
}
// Emit left-shift, then right-shift to sign- or zero-extend.
unsigned TmpReg = makeAnotherReg (newTy);
unsigned shiftWidth = 32 - (8 * TM.getTargetData ().getTypeSize (newTy));
BuildMI (*BB, IP, V8::SLLri, 2, TmpReg).addZImm (shiftWidth).addReg(SrcReg);
if (newTy->isSigned ()) { // sign-extend with SRA
BuildMI(*BB, IP, V8::SRAri, 2, DestReg).addZImm (shiftWidth).addReg(TmpReg);
@ -739,7 +740,7 @@ void V8ISel::emitCastOperation(MachineBasicBlock *BB,
const Type *OldHalfTy = oldTy->isSigned() ? Type::IntTy : Type::UIntTy;
const Type *NewHalfTy = newTy->isSigned() ? Type::IntTy : Type::UIntTy;
unsigned TempReg = emitIntegerCast (BB, IP, OldHalfTy, SrcReg,
NewHalfTy, DestReg+1);
NewHalfTy, DestReg+1, true);
if (newTy->isSigned ()) {
BuildMI (*BB, IP, V8::SRAri, 2, DestReg).addReg (TempReg)
.addZImm (31);