From 6be5e567ce9e1e319321470823f04d7e4caeeca4 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Wed, 22 Oct 2003 04:43:18 +0000 Subject: [PATCH] Update the 'used' flag correctly git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@9366 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Transforms/IPO/FunctionResolution.cpp | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/lib/Transforms/IPO/FunctionResolution.cpp b/lib/Transforms/IPO/FunctionResolution.cpp index 844bc0027d1..b8af50269de 100644 --- a/lib/Transforms/IPO/FunctionResolution.cpp +++ b/lib/Transforms/IPO/FunctionResolution.cpp @@ -245,24 +245,25 @@ bool FunctionResolvingPass::run(Module &M) { // algorithm here to avoid problems with iterators getting invalidated if we // did a one pass scheme. // + bool Changed = false; for (Module::iterator I = M.begin(), E = M.end(); I != E; ) { Function *F = I++; - if (F->use_empty() && F->isExternal()) + if (F->use_empty() && F->isExternal()) { M.getFunctionList().erase(F); - else if (!F->hasInternalLinkage() && !F->getName().empty()) + Changed = true; + } else if (!F->hasInternalLinkage() && !F->getName().empty()) Globals[F->getName()].push_back(F); } for (Module::giterator I = M.gbegin(), E = M.gend(); I != E; ) { GlobalVariable *GV = I++; - if (GV->use_empty() && GV->isExternal()) + if (GV->use_empty() && GV->isExternal()) { M.getGlobalList().erase(GV); - else if (!GV->hasInternalLinkage() && !GV->getName().empty()) + Changed = true; + } else if (!GV->hasInternalLinkage() && !GV->getName().empty()) Globals[GV->getName()].push_back(GV); } - bool Changed = false; - TargetData &TD = getAnalysis(); // Now we have a list of all functions with a particular name. If there is