6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-06-25 16:24:23 +00:00
Code Issues Projects Releases Wiki Activity

Use unique_ptr to handle ownership of Value*s in Cloning unit tests.

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206828 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
David Blaikie
2014-04-21 23:47:47 +00:00
parent b5213bb1b0
commit 6d73b8016e
1 changed files with 25 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
unittests/Transforms/Utils/Cloning.cpp
View File

@ -10,7 +10,6 @@
#include "llvm/Transforms/Utils/Cloning.h" #include "llvm/Transforms/Utils/Cloning.h"
#include "llvm/ADT/ArrayRef.h" #include "llvm/ADT/ArrayRef.h"
#include "llvm/ADT/STLExtras.h" #include "llvm/ADT/STLExtras.h"
#include "llvm/ADT/SmallPtrSet.h"
#include "llvm/IR/Argument.h" #include "llvm/IR/Argument.h"
#include "llvm/IR/Constant.h" #include "llvm/IR/Constant.h"
#include "llvm/IR/DebugInfo.h" #include "llvm/IR/DebugInfo.h"
@ -25,6 +24,8 @@
#include "llvm/IR/LLVMContext.h" #include "llvm/IR/LLVMContext.h"
#include "gtest/gtest.h" #include "gtest/gtest.h"
#include <set>
using namespace llvm; using namespace llvm;
namespace { namespace {
@ -38,34 +39,38 @@ protected:
template <typename T> template <typename T>
T *clone(T *V1) { T *clone(T *V1) {
Value *V2 = V1->clone(); Value *V2 = V1->clone();
Orig.insert(V1); std::unique_ptr<Value> V(V1);
Clones.insert(V2); if (!Orig.insert(std::move(V)).second)
V.release(); // this wasn't the first time we added the element, so the
// set already had ownership
Clones.insert(std::unique_ptr<Value>(V2));
return cast<T>(V2); return cast<T>(V2);
} }
void eraseClones() { void eraseClones() { Clones.clear(); }
DeleteContainerPointers(Clones);
}
virtual void TearDown() { virtual void TearDown() {
eraseClones(); eraseClones();
DeleteContainerPointers(Orig); Orig.clear();
delete V; V.reset();
} }
SmallPtrSet<Value *, 4> Orig; // Erase on exit std::set<std::unique_ptr<Value>> Orig; // Erase on exit
SmallPtrSet<Value *, 4> Clones; // Erase in eraseClones std::set<std::unique_ptr<Value>> Clones; // Erase in eraseClones
LLVMContext context; LLVMContext context;
Value *V; std::unique_ptr<Value> V;
}; };
TEST_F(CloneInstruction, OverflowBits) { TEST_F(CloneInstruction, OverflowBits) {
V = new Argument(Type::getInt32Ty(context)); V = make_unique<Argument>(Type::getInt32Ty(context));
BinaryOperator *Add = BinaryOperator::Create(Instruction::Add, V, V); BinaryOperator *Add =
BinaryOperator *Sub = BinaryOperator::Create(Instruction::Sub, V, V); BinaryOperator::Create(Instruction::Add, V.get(), V.get());
BinaryOperator *Mul = BinaryOperator::Create(Instruction::Mul, V, V); BinaryOperator *Sub =
BinaryOperator::Create(Instruction::Sub, V.get(), V.get());
BinaryOperator *Mul =
BinaryOperator::Create(Instruction::Mul, V.get(), V.get());
BinaryOperator *AddClone = this->clone(Add); BinaryOperator *AddClone = this->clone(Add);
BinaryOperator *SubClone = this->clone(Sub); BinaryOperator *SubClone = this->clone(Sub);
@ -131,12 +136,12 @@ TEST_F(CloneInstruction, OverflowBits) {
} }
TEST_F(CloneInstruction, Inbounds) { TEST_F(CloneInstruction, Inbounds) {
V = new Argument(Type::getInt32PtrTy(context)); V = make_unique<Argument>(Type::getInt32PtrTy(context));
Constant *Z = Constant::getNullValue(Type::getInt32Ty(context)); Constant *Z = Constant::getNullValue(Type::getInt32Ty(context));
std::vector<Value *> ops; std::vector<Value *> ops;
ops.push_back(Z); ops.push_back(Z);
GetElementPtrInst *GEP = GetElementPtrInst::Create(V, ops); GetElementPtrInst *GEP = GetElementPtrInst::Create(V.get(), ops);
EXPECT_FALSE(this->clone(GEP)->isInBounds()); EXPECT_FALSE(this->clone(GEP)->isInBounds());
GEP->setIsInBounds(); GEP->setIsInBounds();
@ -144,9 +149,10 @@ TEST_F(CloneInstruction, Inbounds) {
} }
TEST_F(CloneInstruction, Exact) { TEST_F(CloneInstruction, Exact) {
V = new Argument(Type::getInt32Ty(context)); V = make_unique<Argument>(Type::getInt32Ty(context));
BinaryOperator *SDiv = BinaryOperator::Create(Instruction::SDiv, V, V); BinaryOperator *SDiv =
BinaryOperator::Create(Instruction::SDiv, V.get(), V.get());
EXPECT_FALSE(this->clone(SDiv)->isExact()); EXPECT_FALSE(this->clone(SDiv)->isExact());
SDiv->setIsExact(true); SDiv->setIsExact(true);