From 6dae757a071fc033c1989b2e4eaca9718dc4302c Mon Sep 17 00:00:00 2001 From: Eli Friedman Date: Wed, 22 Jul 2009 08:12:59 +0000 Subject: [PATCH] Don't give a massive inlining cost bonus to available_externally functions with a single use; eliminating the single use may eliminate the function from the current module, but usually doesn't eliminate it from the final program. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@76730 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Transforms/Utils/InlineCost.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/Transforms/Utils/InlineCost.cpp b/lib/Transforms/Utils/InlineCost.cpp index 8925a752b19..9cd47027631 100644 --- a/lib/Transforms/Utils/InlineCost.cpp +++ b/lib/Transforms/Utils/InlineCost.cpp @@ -201,8 +201,7 @@ InlineCost InlineCostAnalyzer::getInlineCost(CallSite CS, // If there is only one call of the function, and it has internal linkage, // make it almost guaranteed to be inlined. // - if ((Callee->hasLocalLinkage() || Callee->hasAvailableExternallyLinkage()) && - Callee->hasOneUse()) + if (Callee->hasLocalLinkage() && Callee->hasOneUse()) InlineCost -= 15000; // If this function uses the coldcc calling convention, prefer not to inline