From 6e994b74921d8519472a087246d7a56731e958d4 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Thu, 4 May 2006 19:36:09 +0000 Subject: [PATCH] Final pass of minor cleanups for MachineInstr git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@28110 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/CodeGen/MachineInstr.h | 10 +++++----- lib/CodeGen/MachineInstr.cpp | 4 ---- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/include/llvm/CodeGen/MachineInstr.h b/include/llvm/CodeGen/MachineInstr.h index 48db3201210..9cf2455f29f 100644 --- a/include/llvm/CodeGen/MachineInstr.h +++ b/include/llvm/CodeGen/MachineInstr.h @@ -71,11 +71,11 @@ public: private: union { - GlobalValue *GV; // LLVM global for MO_GlobalAddress. - int64_t immedVal; // Constant value for an explicit constant - MachineBasicBlock *MBB; // For MO_MachineBasicBlock type - const char *SymbolName; // For MO_ExternalSymbol type - unsigned RegNo; // For MO_Register number for an explicit register + GlobalValue *GV; // For MO_GlobalAddress. + MachineBasicBlock *MBB; // For MO_MachineBasicBlock. + const char *SymbolName; // For MO_ExternalSymbol. + unsigned RegNo; // For MO_Register. + int64_t immedVal; // For MO_Immediate and MO_*Index. } contents; char flags; // see bit field definitions above diff --git a/lib/CodeGen/MachineInstr.cpp b/lib/CodeGen/MachineInstr.cpp index 495da5edfcf..03af3689ef0 100644 --- a/lib/CodeGen/MachineInstr.cpp +++ b/lib/CodeGen/MachineInstr.cpp @@ -9,14 +9,10 @@ // // Methods common to all machine instructions. // -// FIXME: Now that MachineInstrs have parent pointers, they should always -// print themselves using their MachineFunction's TargetMachine. -// //===----------------------------------------------------------------------===// #include "llvm/CodeGen/MachineInstr.h" #include "llvm/CodeGen/MachineFunction.h" -#include "llvm/Value.h" #include "llvm/Target/TargetMachine.h" #include "llvm/Target/TargetInstrInfo.h" #include "llvm/Target/MRegisterInfo.h"