mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2024-08-21 03:29:40 +00:00
Fix a disconcerting bug in Value::isUsedInBasicBlock, which gave wrong answers for blocks larger than 3 instrs.
Also add a unit test. PR15727. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@179370 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
parent
5eacadd649
commit
71c1b22855
@ -118,7 +118,7 @@ bool Value::isUsedInBasicBlock(const BasicBlock *BB) const {
|
||||
for (BasicBlock::const_iterator I = BB->begin(), E = BB->end(); I != E; ++I) {
|
||||
if (std::find(I->op_begin(), I->op_end(), this) != I->op_end())
|
||||
return true;
|
||||
if (MaxBlockSize-- == 0) // If the block is larger fall back to use_iterator
|
||||
if (--MaxBlockSize == 0) // If the block is larger fall back to use_iterator
|
||||
break;
|
||||
}
|
||||
|
||||
|
@ -16,6 +16,7 @@ set(IRSources
|
||||
TypeBuilderTest.cpp
|
||||
TypesTest.cpp
|
||||
ValueMapTest.cpp
|
||||
ValueTest.cpp
|
||||
VerifierTest.cpp
|
||||
WaymarkTest.cpp
|
||||
)
|
||||
|
46
unittests/IR/ValueTest.cpp
Normal file
46
unittests/IR/ValueTest.cpp
Normal file
@ -0,0 +1,46 @@
|
||||
//===- llvm/unittest/IR/ValueTest.cpp - Value unit tests ------------------===//
|
||||
//
|
||||
// The LLVM Compiler Infrastructure
|
||||
//
|
||||
// This file is distributed under the University of Illinois Open Source
|
||||
// License. See LICENSE.TXT for details.
|
||||
//
|
||||
//===----------------------------------------------------------------------===//
|
||||
|
||||
#include "llvm/Assembly/Parser.h"
|
||||
#include "llvm/IR/Function.h"
|
||||
#include "llvm/IR/LLVMContext.h"
|
||||
#include "llvm/IR/Module.h"
|
||||
#include "llvm/IR/Value.h"
|
||||
#include "llvm/Support/SourceMgr.h"
|
||||
#include "gtest/gtest.h"
|
||||
using namespace llvm;
|
||||
|
||||
namespace {
|
||||
|
||||
TEST(ValueTest, UsedInBasicBlock) {
|
||||
LLVMContext C;
|
||||
|
||||
const char *ModuleString = "define void @f(i32 %x, i32 %y) {\n"
|
||||
"bb0:\n"
|
||||
" %y1 = add i32 %y, 1\n"
|
||||
" %y2 = add i32 %y, 1\n"
|
||||
" %y3 = add i32 %y, 1\n"
|
||||
" %y4 = add i32 %y, 1\n"
|
||||
" %y5 = add i32 %y, 1\n"
|
||||
" %y6 = add i32 %y, 1\n"
|
||||
" %y7 = add i32 %y, 1\n"
|
||||
" %y8 = add i32 %x, 1\n"
|
||||
" ret void\n"
|
||||
"}\n";
|
||||
SMDiagnostic Err;
|
||||
Module *M = ParseAssemblyString(ModuleString, NULL, Err, C);
|
||||
|
||||
Function *F = M->getFunction("f");
|
||||
|
||||
EXPECT_FALSE(F->isUsedInBasicBlock(F->begin()));
|
||||
EXPECT_TRUE((++F->arg_begin())->isUsedInBasicBlock(F->begin()));
|
||||
EXPECT_TRUE(F->arg_begin()->isUsedInBasicBlock(F->begin()));
|
||||
}
|
||||
|
||||
} // end anonymous namespace
|
Loading…
Reference in New Issue
Block a user