not: Only consider exit code 3 to be a crash with --crash

This fixes Clang's test/Index/comment-xml-schema.c with Cygwin's
xmllint.exe, which uses exit(3) for XML validation failure.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@211550 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Reid Kleckner 2014-06-23 22:54:33 +00:00
parent b138caba43
commit 71c24112f1

View File

@ -33,10 +33,11 @@ int main(int argc, const char **argv) {
int Result = sys::ExecuteAndWait(Program, argv, nullptr, nullptr, 0, 0, int Result = sys::ExecuteAndWait(Program, argv, nullptr, nullptr, 0, 0,
&ErrMsg); &ErrMsg);
#ifdef _WIN32 #ifdef _WIN32
// Handle abort() in msvcrt -- It has exit code as 3. // Handle abort() in msvcrt -- It has exit code as 3. abort(), aka
// abort(), aka unreachable, may be handled as crash. // unreachable, should be recognized as a crash. However, some binaries use
// FIXME: Could we move this into Win32/Program.inc? // exit code 3 on non-crash failure paths, so only do this if we expect a
if (Result == 3) // crash.
if (ExpectCrash && Result == 3)
Result = -3; Result = -3;
#endif #endif
if (Result < 0) { if (Result < 0) {