From 727552bb899688f9fc473651bef67d4105597b8f Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Thu, 19 Jan 2006 00:46:54 +0000 Subject: [PATCH] If not internalizing, don't mark llvm.global[cd]tors const, as a fix for a hypothetical future boog. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@25430 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Transforms/IPO/Internalize.cpp | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/Transforms/IPO/Internalize.cpp b/lib/Transforms/IPO/Internalize.cpp index d583d888684..861b79a4e0f 100644 --- a/lib/Transforms/IPO/Internalize.cpp +++ b/lib/Transforms/IPO/Internalize.cpp @@ -126,12 +126,15 @@ bool InternalizePass::runOnModule(Module &M) { // if (I->hasAppendingLinkage() && (I->getName() == "llvm.global_ctors" || I->getName() == "llvm.global_dtors")) { - I->setConstant(true); - // If the global ctors/dtors list has no uses, do not internalize it, as // there is no __main in this program, so the asmprinter should handle // it. if (I->use_empty()) continue; + + // Otherwise, also mark the list constant, as we know that it will not + // be mutated any longer, and the makes simple IPO xforms automatically + // better. + I->setConstant(true); } I->setLinkage(GlobalValue::InternalLinkage);