get rid of ExtractValueInst::init's Value argument, it is already passed to the UnaryInstruction ctor

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@52064 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Gabor Greif 2008-06-06 21:06:32 +00:00
parent 929b39f0a0
commit 76aca6f38f
2 changed files with 10 additions and 12 deletions

View File

@ -1457,12 +1457,12 @@ class ExtractValueInst : public UnaryInstruction {
SmallVector<unsigned, 4> Indices;
ExtractValueInst(const ExtractValueInst &EVI);
void init(Value *Agg, const unsigned *Idx, unsigned NumIdx,
void init(const unsigned *Idx, unsigned NumIdx,
const std::string &Name);
void init(Value *Agg, unsigned Idx, const std::string &Name);
void init(unsigned Idx, const std::string &Name);
template<typename InputIterator>
void init(Value *Agg, InputIterator IdxBegin, InputIterator IdxEnd,
void init(InputIterator IdxBegin, InputIterator IdxEnd,
const std::string &Name,
// This argument ensures that we have an iterator we can
// do arithmetic on in constant time
@ -1476,7 +1476,7 @@ class ExtractValueInst : public UnaryInstruction {
assert(NumIdx > 0 && "ExtractValueInst must have at least one index");
// This requires that the iterator points to contiguous memory.
init(Agg, &*IdxBegin, NumIdx, Name); // FIXME: for the general case
init(&*IdxBegin, NumIdx, Name); // FIXME: for the general case
// we have to build an array here
}
@ -1626,7 +1626,7 @@ ExtractValueInst::ExtractValueInst(Value *Agg,
: UnaryInstruction(checkType(getIndexedType(Agg->getType(),
IdxBegin, IdxEnd)),
ExtractValue, Agg, InsertBefore) {
init(Agg, IdxBegin, IdxEnd, Name,
init(IdxBegin, IdxEnd, Name,
typename std::iterator_traits<InputIterator>::iterator_category());
}
template<typename InputIterator>
@ -1638,7 +1638,7 @@ ExtractValueInst::ExtractValueInst(Value *Agg,
: UnaryInstruction(checkType(getIndexedType(Agg->getType(),
IdxBegin, IdxEnd)),
ExtractValue, Agg, InsertAtEnd) {
init(Agg, IdxBegin, IdxEnd, Name,
init(IdxBegin, IdxEnd, Name,
typename std::iterator_traits<InputIterator>::iterator_category());
}

View File

@ -1412,18 +1412,16 @@ InsertValueInst::InsertValueInst(Value *Agg,
// ExtractValueInst Class
//===----------------------------------------------------------------------===//
void ExtractValueInst::init(Value *Agg, const unsigned *Idx, unsigned NumIdx,
void ExtractValueInst::init(const unsigned *Idx, unsigned NumIdx,
const std::string &Name) {
assert(NumOperands == 1 && "NumOperands not initialized?");
Op<0>() = Agg;
Indices.insert(Indices.end(), Idx, Idx + NumIdx);
setName(Name);
}
void ExtractValueInst::init(Value *Agg, unsigned Idx, const std::string &Name) {
void ExtractValueInst::init(unsigned Idx, const std::string &Name) {
assert(NumOperands == 1 && "NumOperands not initialized?");
Op<0>() = Agg;
Indices.push_back(Idx);
setName(Name);
@ -1467,7 +1465,7 @@ ExtractValueInst::ExtractValueInst(Value *Agg,
BasicBlock *InsertAtEnd)
: UnaryInstruction(checkType(getIndexedType(Agg->getType(), &Idx, 1)),
ExtractValue, Agg, InsertAtEnd) {
init(Agg, Idx, Name);
init(Idx, Name);
}
ExtractValueInst::ExtractValueInst(Value *Agg,
@ -1476,7 +1474,7 @@ ExtractValueInst::ExtractValueInst(Value *Agg,
Instruction *InsertBefore)
: UnaryInstruction(checkType(getIndexedType(Agg->getType(), &Idx, 1)),
ExtractValue, Agg, InsertBefore) {
init(Agg, Idx, Name);
init(Idx, Name);
}
//===----------------------------------------------------------------------===//