6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-05-13 01:15:32 +00:00
Code Issues Projects Releases Wiki Activity

eliminate a bunch more unneeded dynamic_cast's.

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@94156 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chris Lattner 2010-01-22 05:37:10 +00:00
parent 3660ecabbb
commit 77c95ed74a
3 changed files with 41 additions and 48 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
lib/Analysis/IPA/CallGraphSCCPass.cpp
View File

@ -400,13 +400,14 @@ void CallGraphSCCPass::assignPassManager(PMStack &PMS,
PMS.top()->getPassManagerType() > PMT_CallGraphPassManager) PMS.top()->getPassManagerType() > PMT_CallGraphPassManager)
PMS.pop(); PMS.pop();
assert (!PMS.empty() && "Unable to handle Call Graph Pass"); assert(!PMS.empty() && "Unable to handle Call Graph Pass");
CGPassManager *CGP = dynamic_cast<CGPassManager *>(PMS.top()); CGPassManager *CGP;
// Create new Call Graph SCC Pass Manager if it does not exist. if (PMS.top()->getPassManagerType() == PMT_CallGraphPassManager)
if (!CGP) { CGP = (CGPassManager*)PMS.top();
else {
assert (!PMS.empty() && "Unable to create Call Graph Pass Manager"); // Create new Call Graph SCC Pass Manager if it does not exist.
assert(!PMS.empty() && "Unable to create Call Graph Pass Manager");
PMDataManager *PMD = PMS.top(); PMDataManager *PMD = PMS.top();
// [1] Create new Call Graph Pass Manager // [1] Create new Call Graph Pass Manager
@ -418,7 +419,7 @@ void CallGraphSCCPass::assignPassManager(PMStack &PMS,
// [3] Assign manager to manage this new manager. This may create // [3] Assign manager to manage this new manager. This may create
// and push new managers into PMS // and push new managers into PMS
Pass *P = dynamic_cast<Pass *>(CGP); Pass *P = CGP;
TPM->schedulePass(P); TPM->schedulePass(P);
// [4] Push new manager into PMS // [4] Push new manager into PMS

45
lib/Analysis/LoopPass.cpp
View File

@ -147,8 +147,7 @@ void LPPassManager::redoLoop(Loop *L) {
void LPPassManager::cloneBasicBlockSimpleAnalysis(BasicBlock *From, void LPPassManager::cloneBasicBlockSimpleAnalysis(BasicBlock *From,
BasicBlock *To, Loop *L) { BasicBlock *To, Loop *L) {
for (unsigned Index = 0; Index < getNumContainedPasses(); ++Index) { for (unsigned Index = 0; Index < getNumContainedPasses(); ++Index) {
Pass *P = getContainedPass(Index); LoopPass *LP = (LoopPass *)getContainedPass(Index);
LoopPass *LP = dynamic_cast<LoopPass *>(P);
LP->cloneBasicBlockAnalysis(From, To, L); LP->cloneBasicBlockAnalysis(From, To, L);
} }
} }
@ -163,8 +162,7 @@ void LPPassManager::deleteSimpleAnalysisValue(Value *V, Loop *L) {
} }
} }
for (unsigned Index = 0; Index < getNumContainedPasses(); ++Index) { for (unsigned Index = 0; Index < getNumContainedPasses(); ++Index) {
Pass *P = getContainedPass(Index); LoopPass *LP = (LoopPass *)getContainedPass(Index);
LoopPass *LP = dynamic_cast<LoopPass *>(P);
LP->deleteAnalysisValue(V, L); LP->deleteAnalysisValue(V, L);
} }
} }
@ -206,10 +204,8 @@ bool LPPassManager::runOnFunction(Function &F) {
I != E; ++I) { I != E; ++I) {
Loop *L = *I; Loop *L = *I;
for (unsigned Index = 0; Index < getNumContainedPasses(); ++Index) { for (unsigned Index = 0; Index < getNumContainedPasses(); ++Index) {
Pass *P = getContainedPass(Index); LoopPass *P = (LoopPass*)getContainedPass(Index);
LoopPass *LP = dynamic_cast<LoopPass *>(P); Changed |= P->doInitialization(L, *this);
if (LP)
Changed |= LP->doInitialization(L, *this);
} }
} }
@ -222,7 +218,7 @@ bool LPPassManager::runOnFunction(Function &F) {
// Run all passes on the current Loop. // Run all passes on the current Loop.
for (unsigned Index = 0; Index < getNumContainedPasses(); ++Index) { for (unsigned Index = 0; Index < getNumContainedPasses(); ++Index) {
Pass *P = getContainedPass(Index); LoopPass *P = (LoopPass*)getContainedPass(Index);
dumpPassInfo(P, EXECUTION_MSG, ON_LOOP_MSG, dumpPassInfo(P, EXECUTION_MSG, ON_LOOP_MSG,
CurrentLoop->getHeader()->getNameStr()); CurrentLoop->getHeader()->getNameStr());
@ -230,12 +226,10 @@ bool LPPassManager::runOnFunction(Function &F) {
initializeAnalysisImpl(P); initializeAnalysisImpl(P);
LoopPass *LP = dynamic_cast<LoopPass *>(P);
assert(LP && "Invalid LPPassManager member");
{ {
PassManagerPrettyStackEntry X(LP, *CurrentLoop->getHeader()); PassManagerPrettyStackEntry X(P, *CurrentLoop->getHeader());
Timer *T = StartPassTimer(P); Timer *T = StartPassTimer(P);
Changed |= LP->runOnLoop(CurrentLoop, *this); Changed |= P->runOnLoop(CurrentLoop, *this);
StopPassTimer(P, T); StopPassTimer(P, T);
} }
@ -256,7 +250,7 @@ bool LPPassManager::runOnFunction(Function &F) {
StopPassTimer(LI, T); StopPassTimer(LI, T);
// Then call the regular verifyAnalysis functions. // Then call the regular verifyAnalysis functions.
verifyPreservedAnalysis(LP); verifyPreservedAnalysis(P);
} }
removeNotPreservedAnalysis(P); removeNotPreservedAnalysis(P);
@ -289,10 +283,8 @@ bool LPPassManager::runOnFunction(Function &F) {
// Finalization // Finalization
for (unsigned Index = 0; Index < getNumContainedPasses(); ++Index) { for (unsigned Index = 0; Index < getNumContainedPasses(); ++Index) {
Pass *P = getContainedPass(Index); LoopPass *P = (LoopPass *)getContainedPass(Index);
LoopPass *LP = dynamic_cast <LoopPass *>(P); Changed |= P->doFinalization();
if (LP)
Changed |= LP->doFinalization();
} }
return Changed; return Changed;
@ -325,12 +317,11 @@ void LoopPass::preparePassManager(PMStack &PMS) {
PMS.top()->getPassManagerType() > PMT_LoopPassManager) PMS.top()->getPassManagerType() > PMT_LoopPassManager)
PMS.pop(); PMS.pop();
LPPassManager *LPPM = dynamic_cast<LPPassManager *>(PMS.top());
// If this pass is destroying high level information that is used // If this pass is destroying high level information that is used
// by other passes that are managed by LPM then do not insert // by other passes that are managed by LPM then do not insert
// this pass in current LPM. Use new LPPassManager. // this pass in current LPM. Use new LPPassManager.
if (LPPM && !LPPM->preserveHigherLevelAnalysis(this)) if (PMS.top()->getPassManagerType() == PMT_LoopPassManager &&
!PMS.top()->preserveHigherLevelAnalysis(this))
PMS.pop(); PMS.pop();
} }
@ -342,11 +333,11 @@ void LoopPass::assignPassManager(PMStack &PMS,
PMS.top()->getPassManagerType() > PMT_LoopPassManager) PMS.top()->getPassManagerType() > PMT_LoopPassManager)
PMS.pop(); PMS.pop();
LPPassManager *LPPM = dynamic_cast<LPPassManager *>(PMS.top()); LPPassManager *LPPM;
if (PMS.top()->getPassManagerType() == PMT_LoopPassManager)
// Create new Loop Pass Manager if it does not exist. LPPM = (LPPassManager*)PMS.top();
if (!LPPM) { else {
// Create new Loop Pass Manager if it does not exist.
assert (!PMS.empty() && "Unable to create Loop Pass Manager"); assert (!PMS.empty() && "Unable to create Loop Pass Manager");
PMDataManager *PMD = PMS.top(); PMDataManager *PMD = PMS.top();
@ -360,7 +351,7 @@ void LoopPass::assignPassManager(PMStack &PMS,
// [3] Assign manager to manage this new manager. This may create // [3] Assign manager to manage this new manager. This may create
// and push new managers into PMS // and push new managers into PMS
Pass *P = dynamic_cast<Pass *>(LPPM); Pass *P = LPPM->getAsPass();
TPM->schedulePass(P); TPM->schedulePass(P);
// [4] Push new manager into PMS // [4] Push new manager into PMS

27
lib/VMCore/PassManager.cpp
View File

@ -1479,7 +1479,7 @@ Pass* MPPassManager::getOnTheFlyPass(Pass *MP, const PassInfo *PI, Function &F){
FPP->releaseMemoryOnTheFly(); FPP->releaseMemoryOnTheFly();
FPP->run(F); FPP->run(F);
return (dynamic_cast<PMTopLevelManager *>(FPP))->findAnalysisPass(PI); return ((PMTopLevelManager*)FPP)->findAnalysisPass(PI);
} }
@ -1626,16 +1626,18 @@ void FunctionPass::assignPassManager(PMStack &PMS,
PassManagerType PreferredType) { PassManagerType PreferredType) {
// Find Module Pass Manager // Find Module Pass Manager
while(!PMS.empty()) { while (!PMS.empty()) {
if (PMS.top()->getPassManagerType() > PMT_FunctionPassManager) if (PMS.top()->getPassManagerType() > PMT_FunctionPassManager)
PMS.pop(); PMS.pop();
else else
break; break;
} }
FPPassManager *FPP = dynamic_cast<FPPassManager *>(PMS.top());
// Create new Function Pass Manager // Create new Function Pass Manager if needed.
if (!FPP) { FPPassManager *FPP;
if (PMS.top()->getPassManagerType() == PMT_FunctionPassManager) {
FPP = (FPPassManager *)PMS.top();
} else {
assert(!PMS.empty() && "Unable to create Function Pass Manager"); assert(!PMS.empty() && "Unable to create Function Pass Manager");
PMDataManager *PMD = PMS.top(); PMDataManager *PMD = PMS.top();
@ -1663,17 +1665,16 @@ void FunctionPass::assignPassManager(PMStack &PMS,
/// in the PM Stack and add self into that manager. /// in the PM Stack and add self into that manager.
void BasicBlockPass::assignPassManager(PMStack &PMS, void BasicBlockPass::assignPassManager(PMStack &PMS,
PassManagerType PreferredType) { PassManagerType PreferredType) {
BBPassManager *BBP = NULL; BBPassManager *BBP;
// Basic Pass Manager is a leaf pass manager. It does not handle // Basic Pass Manager is a leaf pass manager. It does not handle
// any other pass manager. // any other pass manager.
if (!PMS.empty()) if (!PMS.empty() &&
BBP = dynamic_cast<BBPassManager *>(PMS.top()); PMS.top()->getPassManagerType() == PMT_BasicBlockPassManager) {
BBP = (BBPassManager *)PMS.top();
// If leaf manager is not Basic Block Pass manager then create new } else {
// basic Block Pass manager. // If leaf manager is not Basic Block Pass manager then create new
// basic Block Pass manager.
if (!BBP) {
assert(!PMS.empty() && "Unable to create BasicBlock Pass Manager"); assert(!PMS.empty() && "Unable to create BasicBlock Pass Manager");
PMDataManager *PMD = PMS.top(); PMDataManager *PMD = PMS.top();