6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-08-15 22:28:18 +00:00
Code Issues Projects Releases Wiki Activity

Fix an error in ConstantRange::getSignedMax on wrapped ranges. Thanks once

Browse Source 
again to Daniel Dunbar and KLEE!


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@75449 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Nick Lewycky
2009-07-13 04:50:21 +00:00
parent ff84de767a
commit 780905e9f9
2 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/Support/ConstantRange.cpp
View File

@@ -159,14 +159,10 @@ APInt ConstantRange::getSignedMax() const {
else else
return SignedMax; return SignedMax;
} else { } else {
if ((getUpper() - 1).slt(getLower())) { if (getLower().isNegative() == getUpper().isNegative())
if (getLower() != SignedMax)
return SignedMax; return SignedMax;
else else
return getUpper() - 1; return getUpper() - 1;
} else {
return getUpper() - 1;
}
} }
} }

4
unittests/Support/ConstantRangeTest.cpp
View File

@@ -137,6 +137,10 @@ TEST_F(ConstantRangeTest, GetMinsAndMaxes) {
EXPECT_EQ(One.getSignedMin(), APInt(16, 0xa)); EXPECT_EQ(One.getSignedMin(), APInt(16, 0xa));
EXPECT_EQ(Some.getSignedMin(), APInt(16, 0xa)); EXPECT_EQ(Some.getSignedMin(), APInt(16, 0xa));
EXPECT_EQ(Wrap.getSignedMin(), APInt(16, INT16_MIN)); EXPECT_EQ(Wrap.getSignedMin(), APInt(16, INT16_MIN));
// Found by Klee
EXPECT_EQ(ConstantRange(APInt(4, 7), APInt(4, 0)).getSignedMax(),
APInt(4, 7));
} }
TEST_F(ConstantRangeTest, Trunc) { TEST_F(ConstantRangeTest, Trunc) {