Fixed a segfault in gccld.

The original code does not work because the value from WorkList.end() is
invalidated once WorkList.erase() is called.  To ensure proper functionality,
we must ensure that WorkList.erase() is always called before WorkList.end().


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@7673 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
John Criswell 2003-08-07 14:43:13 +00:00
parent ec4f523178
commit 7d3c5795f9

View File

@ -123,8 +123,10 @@ bool GlobalDCE::RemoveIfDead(GlobalValue *GV) {
// If the global variable is still on the worklist, remove it now.
std::vector<GlobalValue*>::iterator I = std::find(WorkList.begin(),
WorkList.end(), GV);
while (I != WorkList.end())
I = std::find(WorkList.erase(I), WorkList.end(), GV);
while (I != WorkList.end()) {
I = WorkList.erase(I);
I = std::find(I, WorkList.end(), GV);
}
return true;
}