From 7f85fbd9de5a4bb1474075b46eb3a8246ea5220d Mon Sep 17 00:00:00 2001 From: Dan Gohman Date: Thu, 11 Sep 2008 00:25:00 +0000 Subject: [PATCH] In my analysis for r56076 I missed the case where the original multiplication overflows. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@56082 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Transforms/Scalar/InstructionCombining.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/Transforms/Scalar/InstructionCombining.cpp b/lib/Transforms/Scalar/InstructionCombining.cpp index 8f578200d65..46ac762b0a7 100644 --- a/lib/Transforms/Scalar/InstructionCombining.cpp +++ b/lib/Transforms/Scalar/InstructionCombining.cpp @@ -5789,7 +5789,8 @@ Instruction *InstCombiner::FoldICmpDivCst(ICmpInst &ICI, BinaryOperator *DivI, // e.g. X/-5 op -3 --> [15, 20) LoBound = Prod; LoOverflow = HiOverflow = ProdOV ? 1 : 0; - HiOverflow = SubWithOverflow(HiBound, Prod, DivRHS, true); + if (!HiOverflow) + HiOverflow = SubWithOverflow(HiBound, Prod, DivRHS, true); } // Dividing by a negative swaps the condition. LT <-> GT