From 80c84fe4ffbb629abcfea959c32bf17356f6cff6 Mon Sep 17 00:00:00 2001 From: "Duncan P. N. Exon Smith" Date: Fri, 17 Apr 2015 16:36:10 +0000 Subject: [PATCH] AsmPrinter: Store MDExpression directly instead of MDNode, NFC Clean up `DebugLocEntry::Value::Expression`'s type while I'm messing around in here anyway. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@235203 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/AsmPrinter/DebugLocEntry.h | 16 +++++++--------- lib/CodeGen/AsmPrinter/DwarfDebug.cpp | 2 +- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/lib/CodeGen/AsmPrinter/DebugLocEntry.h b/lib/CodeGen/AsmPrinter/DebugLocEntry.h index 184fb295784..cd3584ecb57 100644 --- a/lib/CodeGen/AsmPrinter/DebugLocEntry.h +++ b/lib/CodeGen/AsmPrinter/DebugLocEntry.h @@ -17,7 +17,7 @@ namespace llvm { class AsmPrinter; -class MDNode; + /// \brief This struct describes location entries emitted in the .debug_loc /// section. class DebugLocEntry { @@ -28,25 +28,25 @@ class DebugLocEntry { public: /// \brief A single location or constant. struct Value { - Value(const MDNode *Expr, int64_t i) + Value(const MDExpression *Expr, int64_t i) : Expression(Expr), EntryKind(E_Integer) { Constant.Int = i; } - Value(const MDNode *Expr, const ConstantFP *CFP) + Value(const MDExpression *Expr, const ConstantFP *CFP) : Expression(Expr), EntryKind(E_ConstantFP) { Constant.CFP = CFP; } - Value(const MDNode *Expr, const ConstantInt *CIP) + Value(const MDExpression *Expr, const ConstantInt *CIP) : Expression(Expr), EntryKind(E_ConstantInt) { Constant.CIP = CIP; } - Value(const MDNode *Expr, MachineLocation Loc) + Value(const MDExpression *Expr, MachineLocation Loc) : Expression(Expr), EntryKind(E_Location), Loc(Loc) { assert(cast(Expr)->isValid()); } /// Any complex address location expression for this Value. - const MDNode *Expression; + const MDExpression *Expression; /// Type of entry that this represents. enum EntryType { E_Location, E_Integer, E_ConstantFP, E_ConstantInt }; @@ -71,9 +71,7 @@ public: const ConstantInt *getConstantInt() const { return Constant.CIP; } MachineLocation getLoc() const { return Loc; } bool isBitPiece() const { return getExpression()->isBitPiece(); } - DIExpression getExpression() const { - return cast_or_null(Expression); - } + DIExpression getExpression() const { return Expression; } friend bool operator==(const Value &, const Value &); friend bool operator<(const Value &, const Value &); }; diff --git a/lib/CodeGen/AsmPrinter/DwarfDebug.cpp b/lib/CodeGen/AsmPrinter/DwarfDebug.cpp index 7c13f1384aa..e53f5743231 100644 --- a/lib/CodeGen/AsmPrinter/DwarfDebug.cpp +++ b/lib/CodeGen/AsmPrinter/DwarfDebug.cpp @@ -733,7 +733,7 @@ void DwarfDebug::collectVariableInfoFromMMITable( // Get .debug_loc entry for the instruction range starting at MI. static DebugLocEntry::Value getDebugLocValue(const MachineInstr *MI) { - const MDNode *Expr = MI->getDebugExpression(); + const MDExpression *Expr = MI->getDebugExpression(); assert(MI->getNumOperands() == 4); if (MI->getOperand(0).isReg()) {