mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2024-08-23 02:29:18 +00:00
inalloca: Don't remove dead arguments in the presence of inalloca args
It disturbs the layout of the parameters in memory and registers, leading to problems in the backend. The plan for optimizing internal inalloca functions going forward is to essentially SROA the argument memory and demote any captured arguments (things that aren't trivially written by a load or store) to an indirect pointer to a static alloca. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200717 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
parent
07786c2f09
commit
81558937d7
@ -531,6 +531,13 @@ DAE::Liveness DAE::SurveyUses(const Value *V, UseVector &MaybeLiveUses) {
|
|||||||
// well as arguments to functions which have their "address taken".
|
// well as arguments to functions which have their "address taken".
|
||||||
//
|
//
|
||||||
void DAE::SurveyFunction(const Function &F) {
|
void DAE::SurveyFunction(const Function &F) {
|
||||||
|
// Functions with inalloca parameters are expecting args in a particular
|
||||||
|
// register and memory layout.
|
||||||
|
if (F.getAttributes().hasAttrSomewhere(Attribute::InAlloca)) {
|
||||||
|
MarkLive(F);
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
unsigned RetCount = NumRetVals(&F);
|
unsigned RetCount = NumRetVals(&F);
|
||||||
// Assume all return values are dead
|
// Assume all return values are dead
|
||||||
typedef SmallVector<Liveness, 5> RetVals;
|
typedef SmallVector<Liveness, 5> RetVals;
|
||||||
|
@ -28,4 +28,20 @@ define void @caller() {
|
|||||||
ret void
|
ret void
|
||||||
}
|
}
|
||||||
|
|
||||||
|
; We can't remove 'this' here, as that would put argmem in ecx instead of
|
||||||
|
; memory.
|
||||||
|
define internal x86_thiscallcc i32 @unused_this(i32* %this, i32* inalloca %argmem) {
|
||||||
|
%v = load i32* %argmem
|
||||||
|
ret i32 %v
|
||||||
|
}
|
||||||
|
; CHECK-LABEL: define internal x86_thiscallcc i32 @unused_this(i32* %this, i32* inalloca %argmem)
|
||||||
|
|
||||||
|
define i32 @caller2() {
|
||||||
|
%t = alloca i32
|
||||||
|
%m = alloca i32, inalloca
|
||||||
|
store i32 42, i32* %m
|
||||||
|
%v = call x86_thiscallcc i32 @unused_this(i32* %t, i32* inalloca %m)
|
||||||
|
ret i32 %v
|
||||||
|
}
|
||||||
|
|
||||||
; CHECK: attributes #0 = { nounwind }
|
; CHECK: attributes #0 = { nounwind }
|
||||||
|
Loading…
Reference in New Issue
Block a user