From 822a02fb4c3a044becbce2aed751702b5ec16855 Mon Sep 17 00:00:00 2001 From: Yunzhong Gao Date: Tue, 3 Dec 2013 18:05:14 +0000 Subject: [PATCH] Teach the internalize pass to skip dllexported symbols because they could be referenced in a way that even the linker does not see. Differential Revision: http://llvm-reviews.chandlerc.com/D2280 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@196300 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Transforms/IPO/Internalize.cpp | 4 ++++ test/Transforms/Internalize/lists.ll | 9 +++++++++ 2 files changed, 13 insertions(+) diff --git a/lib/Transforms/IPO/Internalize.cpp b/lib/Transforms/IPO/Internalize.cpp index 962d3de3156..dae69ce0915 100644 --- a/lib/Transforms/IPO/Internalize.cpp +++ b/lib/Transforms/IPO/Internalize.cpp @@ -115,6 +115,10 @@ static bool shouldInternalize(const GlobalValue &GV, if (GV.hasAvailableExternallyLinkage()) return false; + // Assume that dllexported symbols are referenced elsewhere + if (GV.hasDLLExportLinkage()) + return false; + // Already has internal linkage if (GV.hasLocalLinkage()) return false; diff --git a/test/Transforms/Internalize/lists.ll b/test/Transforms/Internalize/lists.ll index 83e441a2dfe..637d701524e 100644 --- a/test/Transforms/Internalize/lists.ll +++ b/test/Transforms/Internalize/lists.ll @@ -48,3 +48,12 @@ define void @foo() { define available_externally void @bar() { ret void } + +; ALL: define dllexport void @export_foo() { +; FOO_AND_J: define dllexport void @export_foo() { +; FOO_AND_BAR: define dllexport void @export_foo() { +; FOO_J_AND_BAR: define dllexport void @export_foo() { +define dllexport void @export_foo() { + ret void +} +