mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2024-08-23 02:29:18 +00:00
CodeGen: move over-zealous assert into actual if statement.
It's quite possible to encounter an insertvalue instruction that's more deeply nested than the value we're looking for, but when that happens we really mustn't compare beyond the end of the index array. Since I couldn't see any guarantees about what comparisons std::equal makes, we probably need to directly check the size beforehand. In practice, I suspect most std::equal implementations would probably bail early, which would be OK. But just in case... rdar://20834485 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@236635 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
parent
7838051bda
commit
84b8c10729
@ -295,9 +295,8 @@ static const Value *getNoopInput(const Value *V,
|
||||
} else if (const InsertValueInst *IVI = dyn_cast<InsertValueInst>(V)) {
|
||||
// Value may come from either the aggregate or the scalar
|
||||
ArrayRef<unsigned> InsertLoc = IVI->getIndices();
|
||||
assert(ValLoc.size() >= InsertLoc.size() && "extracting too deeply");
|
||||
if (std::equal(InsertLoc.begin(), InsertLoc.end(),
|
||||
ValLoc.rbegin())) {
|
||||
if (ValLoc.size() >= InsertLoc.size() &&
|
||||
std::equal(InsertLoc.begin(), InsertLoc.end(), ValLoc.rbegin())) {
|
||||
// The type being inserted is a nested sub-type of the aggregate; we
|
||||
// have to remove those initial indices to get the location we're
|
||||
// interested in for the operand.
|
||||
|
@ -122,3 +122,22 @@ define { [3 x float] } @test_add_elem() {
|
||||
%res.012 = insertvalue { [3 x float] } %res.01, float 1.000000e+00, 0, 2
|
||||
ret { [3 x float] } %res.012
|
||||
}
|
||||
|
||||
declare double @get_double()
|
||||
define { double, [2 x double] } @test_mismatched_insert() {
|
||||
; CHECK-LABEL: test_mismatched_insert:
|
||||
; CHECK: bl get_double
|
||||
; CHECK: bl get_double
|
||||
; CHECK: bl get_double
|
||||
; CHECK: ret
|
||||
|
||||
%val0 = call double @get_double()
|
||||
%val1 = call double @get_double()
|
||||
%val2 = tail call double @get_double()
|
||||
|
||||
%res.0 = insertvalue { double, [2 x double] } undef, double %val0, 0
|
||||
%res.01 = insertvalue { double, [2 x double] } %res.0, double %val1, 1, 0
|
||||
%res.012 = insertvalue { double, [2 x double] } %res.01, double %val2, 1, 1
|
||||
|
||||
ret { double, [2 x double] } %res.012
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user