diff --git a/lib/CodeGen/SimpleRegisterCoalescing.cpp b/lib/CodeGen/SimpleRegisterCoalescing.cpp index 3ea35c6eab2..6a110f0b87d 100644 --- a/lib/CodeGen/SimpleRegisterCoalescing.cpp +++ b/lib/CodeGen/SimpleRegisterCoalescing.cpp @@ -942,9 +942,11 @@ bool SimpleRegisterCoalescing::JoinCopy(CopyRec &TheCopy, bool &Again) { unsigned OldSubIdx = isExtSubReg ? CopyMI->getOperand(0).getSubReg() : CopyMI->getOperand(2).getSubReg(); if (OldSubIdx) { - if (OldSubIdx == SubIdx) + if (OldSubIdx == SubIdx && !differingRegisterClasses(SrcReg, DstReg)) // r1024<2> = EXTRACT_SUBREG r1025, 2. Then r1024 has already been // coalesced to a larger register so the subreg indices cancel out. + // Also check if the other larger register is of the same register + // class as the would be resulting register. SubIdx = 0; else { DOUT << "\t Sub-register indices mismatch.\n"; diff --git a/test/CodeGen/X86/2008-04-28-CoalescerBug.ll b/test/CodeGen/X86/2008-04-28-CoalescerBug.ll new file mode 100644 index 00000000000..e970a4267df --- /dev/null +++ b/test/CodeGen/X86/2008-04-28-CoalescerBug.ll @@ -0,0 +1,166 @@ +; RUN: llvm-as < %s | llc -mtriple=x86_64-apple-darwin | grep movl | not grep {r\[abcd\]x} +; RUN: llvm-as < %s | llc -mtriple=x86_64-apple-darwin | grep movl | not grep {r\[ds\]i} +; RUN: llvm-as < %s | llc -mtriple=x86_64-apple-darwin | grep movl | not grep {r\[bs\]p} + + %struct.BITMAP = type { i16, i16, i32, i32, i32, i32, i32, i32, i8*, i8* } + %struct.BltData = type { float, float, float, float } + %struct.BltDepth = type { i32, i8**, i32, %struct.BITMAP* (%struct.BltDepth**, %struct.BITMAP*, i32, i32, float*, float, i32)*, i32 (%struct.BltDepth**, %struct.BltOp*)*, i32 (%struct.BltDepth**, %struct.BltOp*, %struct.BltImg*)*, i32 (%struct.BltDepth**, %struct.BltOp*, %struct.BltSh*)*, [28 x [2 x [2 x i32]]]*, %struct.BltData* } + %struct.BltImg = type { i32, i8, i8, i8, float, float*, float*, i32, i32, float*, i32 (i8*, i8*, i8**, i32*, i8**, i32*)*, i8* } + %struct.BltOp = type { i8, i8, i8, i8, i32, i32, i32, i32, i32, i32, i32, i32, i8*, i8*, i32, i32, i32, i32, i32, i32, i32, i8*, i8*, i32, i32, i32, i32, i32, i32, i32, i8* } + %struct.BltSh = type { i8, i8, i8, i8, float, float*, float*, float*, float*, i32, i32, float*, float*, float* } + +define void @t(%struct.BltDepth* %depth, %struct.BltOp* %bop, i32 %mode) nounwind { +entry: + switch i32 %mode, label %return [ + i32 1, label %bb2898.us + i32 18, label %bb13086.preheader + ] + +bb13086.preheader: ; preds = %entry + %tmp13098 = icmp eq i32 0, 0 ; [#uses=1] + %tmp13238 = icmp eq i32 0, 0 ; [#uses=1] + br label %bb13088 + +bb2898.us: ; preds = %bb2898.us, %entry + br label %bb2898.us + +bb13088: ; preds = %bb13572, %bb13567, %bb13107, %bb13086.preheader + br i1 %tmp13098, label %bb13107, label %bb13101 + +bb13101: ; preds = %bb13088 + br label %bb13107 + +bb13107: ; preds = %bb13101, %bb13088 + %iftmp.684.0 = phi i32 [ 0, %bb13101 ], [ 65535, %bb13088 ] ; [#uses=2] + %tmp13111 = load i64* null, align 8 ; [#uses=3] + %tmp13116 = lshr i64 %tmp13111, 16 ; [#uses=1] + %tmp1311613117 = trunc i64 %tmp13116 to i32 ; [#uses=1] + %tmp13118 = and i32 %tmp1311613117, 65535 ; [#uses=1] + %tmp13120 = lshr i64 %tmp13111, 32 ; [#uses=1] + %tmp1312013121 = trunc i64 %tmp13120 to i32 ; [#uses=1] + %tmp13122 = and i32 %tmp1312013121, 65535 ; [#uses=2] + %tmp13124 = lshr i64 %tmp13111, 48 ; [#uses=1] + %tmp1312413125 = trunc i64 %tmp13124 to i32 ; [#uses=2] + %tmp1314013141not = xor i16 0, -1 ; [#uses=1] + %tmp1314013141not13142 = zext i16 %tmp1314013141not to i32 ; [#uses=3] + %tmp13151 = mul i32 %tmp13122, %tmp1314013141not13142 ; [#uses=1] + %tmp13154 = mul i32 %tmp1312413125, %tmp1314013141not13142 ; [#uses=1] + %tmp13157 = mul i32 %iftmp.684.0, %tmp1314013141not13142 ; [#uses=1] + %tmp13171 = add i32 %tmp13151, 1 ; [#uses=1] + %tmp13172 = add i32 %tmp13171, 0 ; [#uses=1] + %tmp13176 = add i32 %tmp13154, 1 ; [#uses=1] + %tmp13177 = add i32 %tmp13176, 0 ; [#uses=1] + %tmp13181 = add i32 %tmp13157, 1 ; [#uses=1] + %tmp13182 = add i32 %tmp13181, 0 ; [#uses=1] + %tmp13188 = lshr i32 %tmp13172, 16 ; [#uses=1] + %tmp13190 = lshr i32 %tmp13177, 16 ; [#uses=1] + %tmp13192 = lshr i32 %tmp13182, 16 ; [#uses=1] + %tmp13198 = sub i32 %tmp13118, 0 ; [#uses=1] + %tmp13201 = sub i32 %tmp13122, %tmp13188 ; [#uses=1] + %tmp13204 = sub i32 %tmp1312413125, %tmp13190 ; [#uses=1] + %tmp13207 = sub i32 %iftmp.684.0, %tmp13192 ; [#uses=1] + %tmp1320813209 = zext i32 %tmp13204 to i64 ; [#uses=1] + %tmp13211 = shl i64 %tmp1320813209, 48 ; [#uses=1] + %tmp1321213213 = zext i32 %tmp13201 to i64 ; [#uses=1] + %tmp13214 = shl i64 %tmp1321213213, 32 ; [#uses=1] + %tmp13215 = and i64 %tmp13214, 281470681743360 ; [#uses=1] + %tmp1321713218 = zext i32 %tmp13198 to i64 ; [#uses=1] + %tmp13219 = shl i64 %tmp1321713218, 16 ; [#uses=1] + %tmp13220 = and i64 %tmp13219, 4294901760 ; [#uses=1] + %tmp13216 = or i64 %tmp13211, 0 ; [#uses=1] + %tmp13221 = or i64 %tmp13216, %tmp13215 ; [#uses=1] + %tmp13225 = or i64 %tmp13221, %tmp13220 ; [#uses=4] + %tmp1322713228 = trunc i32 %tmp13207 to i16 ; [#uses=4] + %tmp13233 = icmp eq i16 %tmp1322713228, 0 ; [#uses=1] + br i1 %tmp13233, label %bb13088, label %bb13236 + +bb13236: ; preds = %bb13107 + br i1 false, label %bb13567, label %bb13252 + +bb13252: ; preds = %bb13236 + %tmp1329013291 = zext i16 %tmp1322713228 to i64 ; [#uses=8] + %tmp13296 = lshr i64 %tmp13225, 16 ; [#uses=1] + %tmp13297 = and i64 %tmp13296, 65535 ; [#uses=1] + %tmp13299 = lshr i64 %tmp13225, 32 ; [#uses=1] + %tmp13300 = and i64 %tmp13299, 65535 ; [#uses=1] + %tmp13302 = lshr i64 %tmp13225, 48 ; [#uses=1] + %tmp13306 = sub i64 %tmp1329013291, 0 ; [#uses=0] + %tmp13309 = sub i64 %tmp1329013291, %tmp13297 ; [#uses=1] + %tmp13312 = sub i64 %tmp1329013291, %tmp13300 ; [#uses=1] + %tmp13315 = sub i64 %tmp1329013291, %tmp13302 ; [#uses=1] + %tmp13318 = mul i64 %tmp1329013291, %tmp1329013291 ; [#uses=1] + br i1 false, label %bb13339, label %bb13324 + +bb13324: ; preds = %bb13252 + br i1 false, label %bb13339, label %bb13330 + +bb13330: ; preds = %bb13324 + %tmp13337 = sdiv i64 0, 0 ; [#uses=1] + br label %bb13339 + +bb13339: ; preds = %bb13330, %bb13324, %bb13252 + %r0120.0 = phi i64 [ %tmp13337, %bb13330 ], [ 0, %bb13252 ], [ 4294836225, %bb13324 ] ; [#uses=1] + br i1 false, label %bb13360, label %bb13345 + +bb13345: ; preds = %bb13339 + br i1 false, label %bb13360, label %bb13351 + +bb13351: ; preds = %bb13345 + %tmp13354 = mul i64 0, %tmp13318 ; [#uses=1] + %tmp13357 = sub i64 %tmp1329013291, %tmp13309 ; [#uses=1] + %tmp13358 = sdiv i64 %tmp13354, %tmp13357 ; [#uses=1] + br label %bb13360 + +bb13360: ; preds = %bb13351, %bb13345, %bb13339 + %r1121.0 = phi i64 [ %tmp13358, %bb13351 ], [ 0, %bb13339 ], [ 4294836225, %bb13345 ] ; [#uses=1] + br i1 false, label %bb13402, label %bb13387 + +bb13387: ; preds = %bb13360 + br label %bb13402 + +bb13402: ; preds = %bb13387, %bb13360 + %r3123.0 = phi i64 [ 0, %bb13360 ], [ 4294836225, %bb13387 ] ; [#uses=1] + %tmp13404 = icmp eq i16 %tmp1322713228, -1 ; [#uses=1] + br i1 %tmp13404, label %bb13435, label %bb13407 + +bb13407: ; preds = %bb13402 + br label %bb13435 + +bb13435: ; preds = %bb13407, %bb13402 + %r0120.1 = phi i64 [ 0, %bb13407 ], [ %r0120.0, %bb13402 ] ; [#uses=0] + %r1121.1 = phi i64 [ 0, %bb13407 ], [ %r1121.0, %bb13402 ] ; [#uses=0] + %r3123.1 = phi i64 [ 0, %bb13407 ], [ %r3123.0, %bb13402 ] ; [#uses=0] + %tmp13450 = mul i64 0, %tmp13312 ; [#uses=0] + %tmp13455 = mul i64 0, %tmp13315 ; [#uses=0] + %tmp13461 = add i64 0, %tmp1329013291 ; [#uses=1] + %tmp13462 = mul i64 %tmp13461, 65535 ; [#uses=1] + %tmp13466 = sub i64 %tmp13462, 0 ; [#uses=1] + %tmp13526 = add i64 %tmp13466, 1 ; [#uses=1] + %tmp13527 = add i64 %tmp13526, 0 ; [#uses=1] + %tmp13528 = ashr i64 %tmp13527, 16 ; [#uses=4] + %tmp13536 = sub i64 %tmp13528, 0 ; [#uses=1] + %tmp13537 = shl i64 %tmp13536, 32 ; [#uses=1] + %tmp13538 = and i64 %tmp13537, 281470681743360 ; [#uses=1] + %tmp13542 = sub i64 %tmp13528, 0 ; [#uses=1] + %tmp13543 = shl i64 %tmp13542, 16 ; [#uses=1] + %tmp13544 = and i64 %tmp13543, 4294901760 ; [#uses=1] + %tmp13548 = sub i64 %tmp13528, 0 ; [#uses=1] + %tmp13549 = and i64 %tmp13548, 65535 ; [#uses=1] + %tmp13539 = or i64 %tmp13538, 0 ; [#uses=1] + %tmp13545 = or i64 %tmp13539, %tmp13549 ; [#uses=1] + %tmp13550 = or i64 %tmp13545, %tmp13544 ; [#uses=1] + %tmp1355213553 = trunc i64 %tmp13528 to i16 ; [#uses=1] + br label %bb13567 + +bb13567: ; preds = %bb13435, %bb13236 + %tsp1040.0.0 = phi i64 [ %tmp13550, %bb13435 ], [ %tmp13225, %bb13236 ] ; [#uses=0] + %tsp1040.1.0 = phi i16 [ %tmp1355213553, %bb13435 ], [ %tmp1322713228, %bb13236 ] ; [#uses=1] + br i1 %tmp13238, label %bb13088, label %bb13572 + +bb13572: ; preds = %bb13567 + store i16 %tsp1040.1.0, i16* null, align 2 + br label %bb13088 + +return: ; preds = %entry + ret void +}