Removing the static initializer in ManagedStatic.cpp by using llvm_call_once to initialize the ManagedStatic mutex.

Summary:
This patch adds an llvm_call_once which is a wrapper around std::call_once on platforms where it is available and devoid of bugs. The patch also migrates the ManagedStatic mutex to be allocated using llvm_call_once.

These changes are philosophically equivalent to the changes added in r219638, which were reverted due to a hang on Win32 which was the result of a bug in the Windows implementation of std::call_once.

Reviewers: aaron.ballman, chapuni, chandlerc, rnk

Reviewed By: rnk

Subscribers: majnemer, llvm-commits

Differential Revision: http://reviews.llvm.org/D5922

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@220932 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chris Bieneman
2014-10-30 22:07:09 +00:00
parent 76ebe3d35c
commit 8744520b53
6 changed files with 81 additions and 4 deletions

View File

@@ -15,6 +15,14 @@
#ifndef LLVM_SUPPORT_THREADING_H
#define LLVM_SUPPORT_THREADING_H
#include "llvm/Config/llvm-config.h" // for LLVM_ON_UNIX
#if defined(LLVM_ON_UNIX)
#include <mutex>
#else
#include "llvm/Support/Atomic.h"
#endif
namespace llvm {
/// Returns true if LLVM is compiled with support for multi-threading, and
/// false otherwise.
@@ -33,6 +41,35 @@ namespace llvm {
/// the thread stack.
void llvm_execute_on_thread(void (*UserFn)(void*), void *UserData,
unsigned RequestedStackSize = 0);
#if defined(LLVM_ON_UNIX)
typedef std::once_flag once_flag;
#define LLVM_DEFINE_ONCE_FLAG(flag) static once_flag flag
#else
enum InitStatus {
Done = -1,
Uninitialized = 0,
Wait = 1
};
typedef volatile sys::cas_flag once_flag;
#define LLVM_DEFINE_ONCE_FLAG(flag) static once_flag flag = Uninitialized
#endif
/// \brief Execute the function specified as a parameter once.
///
/// Typical usage:
/// \code
/// void foo() {...};
/// ...
/// LLVM_DEFINE_ONCE_FLAG(flag);
/// call_once(flag, foo);
/// \endcode
///
/// \param flag Flag used for tracking whether or not this has run.
/// \param UserFn Function to call once.
void call_once(once_flag&, void (*)(void));
}
#endif