[X86] Cleanup X86WindowsTargetObjectFile::getSectionForConstant

No functionality changed, just keeping things clean.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@240762 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
David Majnemer 2015-06-26 07:03:12 +00:00
parent fabf219603
commit 891c0208fe

View File

@ -131,52 +131,40 @@ static std::string APIntToHexString(const APInt &AI) {
return HexString; return HexString;
} }
static std::string scalarConstantToHexString(const Constant *C) { static std::string scalarConstantToHexString(const Constant *C) {
Type *Ty = C->getType(); Type *Ty = C->getType();
APInt AI;
if (isa<UndefValue>(C)) { if (isa<UndefValue>(C)) {
AI = APInt(Ty->getPrimitiveSizeInBits(), /*val=*/0); return APIntToHexString(APInt::getNullValue(Ty->getPrimitiveSizeInBits()));
} else if (Ty->isFloatTy() || Ty->isDoubleTy()) { } else if (const auto *CFP = dyn_cast<ConstantFP>(C)) {
const auto *CFP = cast<ConstantFP>(C); return APIntToHexString(CFP->getValueAPF().bitcastToAPInt());
AI = CFP->getValueAPF().bitcastToAPInt(); } else if (const auto *CI = dyn_cast<ConstantInt>(C)) {
} else if (Ty->isIntegerTy()) { return APIntToHexString(CI->getValue());
const auto *CI = cast<ConstantInt>(C); } else if (const auto *VTy = dyn_cast<VectorType>(Ty)) {
AI = CI->getValue(); std::string HexString;
} else { for (int I = VTy->getNumElements() - 1, E = -1; I != E; --I)
llvm_unreachable("unexpected constant pool element type!"); HexString += scalarConstantToHexString(C->getAggregateElement(I));
return HexString;
} }
return APIntToHexString(AI); llvm_unreachable("unexpected constant pool element type!");
} }
MCSection * MCSection *
X86WindowsTargetObjectFile::getSectionForConstant(SectionKind Kind, X86WindowsTargetObjectFile::getSectionForConstant(SectionKind Kind,
const Constant *C) const { const Constant *C) const {
if (Kind.isReadOnly()) { if (Kind.isMergeableConst() && C) {
if (C) { const unsigned Characteristics = COFF::IMAGE_SCN_CNT_INITIALIZED_DATA |
Type *Ty = C->getType(); COFF::IMAGE_SCN_MEM_READ |
SmallString<32> COMDATSymName; COFF::IMAGE_SCN_LNK_COMDAT;
if (Ty->isFloatTy() || Ty->isDoubleTy()) { std::string COMDATSymName;
COMDATSymName = "__real@"; if (Kind.isMergeableConst4() || Kind.isMergeableConst8())
COMDATSymName += scalarConstantToHexString(C); COMDATSymName = "__real@" + scalarConstantToHexString(C);
} else if (const auto *VTy = dyn_cast<VectorType>(Ty)) { else if (Kind.isMergeableConst16())
uint64_t NumBits = VTy->getBitWidth(); COMDATSymName = "__xmm@" + scalarConstantToHexString(C);
if (NumBits == 128 || NumBits == 256) {
COMDATSymName = NumBits == 128 ? "__xmm@" : "__ymm@"; if (!COMDATSymName.empty())
for (int I = VTy->getNumElements() - 1, E = -1; I != E; --I) return getContext().getCOFFSection(".rdata", Characteristics, Kind,
COMDATSymName += COMDATSymName,
scalarConstantToHexString(C->getAggregateElement(I)); COFF::IMAGE_COMDAT_SELECT_ANY);
}
}
if (!COMDATSymName.empty()) {
unsigned Characteristics = COFF::IMAGE_SCN_CNT_INITIALIZED_DATA |
COFF::IMAGE_SCN_MEM_READ |
COFF::IMAGE_SCN_LNK_COMDAT;
return getContext().getCOFFSection(".rdata", Characteristics, Kind,
COMDATSymName,
COFF::IMAGE_COMDAT_SELECT_ANY);
}
}
} }
return TargetLoweringObjectFile::getSectionForConstant(Kind, C); return TargetLoweringObjectFile::getSectionForConstant(Kind, C);