mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2025-06-17 04:24:00 +00:00
CR feedback for r195166: Add comments regarding type unit mapping and type units disabling cross-CU sharing.
Changes suggested by Manman Ren. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195262 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
@ -112,8 +112,13 @@ int64_t CompileUnit::getDefaultLowerBound() const {
|
||||
|
||||
/// Check whether the DIE for this MDNode can be shared across CUs.
|
||||
static bool isShareableAcrossCUs(DIDescriptor D) {
|
||||
// When the MDNode can be part of the type system, the DIE can be
|
||||
// shared across CUs.
|
||||
// When the MDNode can be part of the type system, the DIE can be shared
|
||||
// across CUs.
|
||||
// Combining type units and cross-CU DIE sharing is lower value (since
|
||||
// cross-CU DIE sharing is used in LTO and removes type redundancy at that
|
||||
// level already) but may be implementable for some value in projects
|
||||
// building multiple independent libraries with LTO and then linking those
|
||||
// together.
|
||||
return (D.isType() ||
|
||||
(D.isSubprogram() && !DISubprogram(D).isDefinition())) &&
|
||||
!GenerateTypeUnits;
|
||||
|
Reference in New Issue
Block a user