mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2024-07-21 02:29:22 +00:00
Fix logic error optimizing "icmp pred (urem X, Y), Y" where pred is signed.
Fixes PR16605. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@186229 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
parent
434c0bd2a5
commit
8a23270ce6
@ -2246,6 +2246,7 @@ static Value *SimplifyICmpInst(unsigned Predicate, Value *LHS, Value *RHS,
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// icmp pred (urem X, Y), Y
|
||||||
if (LBO && match(LBO, m_URem(m_Value(), m_Specific(RHS)))) {
|
if (LBO && match(LBO, m_URem(m_Value(), m_Specific(RHS)))) {
|
||||||
bool KnownNonNegative, KnownNegative;
|
bool KnownNonNegative, KnownNegative;
|
||||||
switch (Pred) {
|
switch (Pred) {
|
||||||
@ -2253,7 +2254,7 @@ static Value *SimplifyICmpInst(unsigned Predicate, Value *LHS, Value *RHS,
|
|||||||
break;
|
break;
|
||||||
case ICmpInst::ICMP_SGT:
|
case ICmpInst::ICMP_SGT:
|
||||||
case ICmpInst::ICMP_SGE:
|
case ICmpInst::ICMP_SGE:
|
||||||
ComputeSignBit(LHS, KnownNonNegative, KnownNegative, Q.TD);
|
ComputeSignBit(RHS, KnownNonNegative, KnownNegative, Q.TD);
|
||||||
if (!KnownNonNegative)
|
if (!KnownNonNegative)
|
||||||
break;
|
break;
|
||||||
// fall-through
|
// fall-through
|
||||||
@ -2263,7 +2264,7 @@ static Value *SimplifyICmpInst(unsigned Predicate, Value *LHS, Value *RHS,
|
|||||||
return getFalse(ITy);
|
return getFalse(ITy);
|
||||||
case ICmpInst::ICMP_SLT:
|
case ICmpInst::ICMP_SLT:
|
||||||
case ICmpInst::ICMP_SLE:
|
case ICmpInst::ICMP_SLE:
|
||||||
ComputeSignBit(LHS, KnownNonNegative, KnownNegative, Q.TD);
|
ComputeSignBit(RHS, KnownNonNegative, KnownNegative, Q.TD);
|
||||||
if (!KnownNonNegative)
|
if (!KnownNonNegative)
|
||||||
break;
|
break;
|
||||||
// fall-through
|
// fall-through
|
||||||
@ -2273,6 +2274,8 @@ static Value *SimplifyICmpInst(unsigned Predicate, Value *LHS, Value *RHS,
|
|||||||
return getTrue(ITy);
|
return getTrue(ITy);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// icmp pred X, (urem Y, X)
|
||||||
if (RBO && match(RBO, m_URem(m_Value(), m_Specific(LHS)))) {
|
if (RBO && match(RBO, m_URem(m_Value(), m_Specific(LHS)))) {
|
||||||
bool KnownNonNegative, KnownNegative;
|
bool KnownNonNegative, KnownNegative;
|
||||||
switch (Pred) {
|
switch (Pred) {
|
||||||
@ -2280,7 +2283,7 @@ static Value *SimplifyICmpInst(unsigned Predicate, Value *LHS, Value *RHS,
|
|||||||
break;
|
break;
|
||||||
case ICmpInst::ICMP_SGT:
|
case ICmpInst::ICMP_SGT:
|
||||||
case ICmpInst::ICMP_SGE:
|
case ICmpInst::ICMP_SGE:
|
||||||
ComputeSignBit(RHS, KnownNonNegative, KnownNegative, Q.TD);
|
ComputeSignBit(LHS, KnownNonNegative, KnownNegative, Q.TD);
|
||||||
if (!KnownNonNegative)
|
if (!KnownNonNegative)
|
||||||
break;
|
break;
|
||||||
// fall-through
|
// fall-through
|
||||||
@ -2290,7 +2293,7 @@ static Value *SimplifyICmpInst(unsigned Predicate, Value *LHS, Value *RHS,
|
|||||||
return getTrue(ITy);
|
return getTrue(ITy);
|
||||||
case ICmpInst::ICMP_SLT:
|
case ICmpInst::ICMP_SLT:
|
||||||
case ICmpInst::ICMP_SLE:
|
case ICmpInst::ICMP_SLE:
|
||||||
ComputeSignBit(RHS, KnownNonNegative, KnownNegative, Q.TD);
|
ComputeSignBit(LHS, KnownNonNegative, KnownNegative, Q.TD);
|
||||||
if (!KnownNonNegative)
|
if (!KnownNonNegative)
|
||||||
break;
|
break;
|
||||||
// fall-through
|
// fall-through
|
||||||
|
@ -480,7 +480,7 @@ define i1 @urem5(i16 %X, i32 %Y) {
|
|||||||
%B = urem i32 %A, %Y
|
%B = urem i32 %A, %Y
|
||||||
%C = icmp slt i32 %B, %Y
|
%C = icmp slt i32 %B, %Y
|
||||||
ret i1 %C
|
ret i1 %C
|
||||||
; CHECK: ret i1 true
|
; CHECK-NOT: ret i1 true
|
||||||
}
|
}
|
||||||
|
|
||||||
define i1 @urem6(i32 %X, i32 %Y) {
|
define i1 @urem6(i32 %X, i32 %Y) {
|
||||||
@ -491,6 +491,14 @@ define i1 @urem6(i32 %X, i32 %Y) {
|
|||||||
; CHECK: ret i1 true
|
; CHECK: ret i1 true
|
||||||
}
|
}
|
||||||
|
|
||||||
|
define i1 @urem7(i32 %X) {
|
||||||
|
; CHECK: @urem7
|
||||||
|
%A = urem i32 1, %X
|
||||||
|
%B = icmp sgt i32 %A, %X
|
||||||
|
ret i1 %B
|
||||||
|
; CHECK-NOT: ret i1 false
|
||||||
|
}
|
||||||
|
|
||||||
define i1 @srem1(i32 %X) {
|
define i1 @srem1(i32 %X) {
|
||||||
; CHECK: @srem1
|
; CHECK: @srem1
|
||||||
%A = srem i32 %X, -5
|
%A = srem i32 %X, -5
|
||||||
|
Loading…
Reference in New Issue
Block a user