6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-06-21 02:24:22 +00:00
Code Issues Projects Releases Wiki Activity

Common symbols are not undefined, at least for ObjectFile.

Browse Source 
They are implemented like that in some object formats, but for the interface
provided by lib/Object, SF_Undefined and SF_Common are different things.

This matches the ELF and COFF implementation and fixes llvm-nm for MachO.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@241587 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Rafael Espindola
2015-07-07 14:26:39 +00:00
parent 6b24d0a9a7
commit 8b3aaabd30
2 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/Object/MachOObjectFile.cpp
View File

@ -418,9 +418,6 @@ uint32_t MachOObjectFile::getSymbolFlags(DataRefImpl DRI) const {
uint32_t Result = SymbolRef::SF_None; uint32_t Result = SymbolRef::SF_None;
if ((MachOType & MachO::N_TYPE) == MachO::N_UNDF)
Result |= SymbolRef::SF_Undefined;
if ((MachOType & MachO::N_TYPE) == MachO::N_INDR) if ((MachOType & MachO::N_TYPE) == MachO::N_INDR)
Result |= SymbolRef::SF_Indirect; Result |= SymbolRef::SF_Indirect;
@ -432,6 +429,8 @@ uint32_t MachOObjectFile::getSymbolFlags(DataRefImpl DRI) const {
if ((MachOType & MachO::N_TYPE) == MachO::N_UNDF) { if ((MachOType & MachO::N_TYPE) == MachO::N_UNDF) {
if (getNValue(DRI)) if (getNValue(DRI))
Result |= SymbolRef::SF_Common; Result |= SymbolRef::SF_Common;
else
Result |= SymbolRef::SF_Undefined;
} }
if (!(MachOType & MachO::N_PEXT)) if (!(MachOType & MachO::N_PEXT))

9
test/Object/X86/nm-macho.s Normal file
View File

@ -0,0 +1,9 @@
// RUN: llvm-mc %s -o %t -filetype=obj -triple=x86_64-apple-darwin
// RUN: llvm-nm -n %t | FileCheck %s
// CHECK: 0000000000000000 t _f
// CHECK: 0000000000000004 C _a
_f:
retq
.comm _a,4