diff --git a/lib/VMCore/Verifier.cpp b/lib/VMCore/Verifier.cpp index 58bf485512a..25826e106cb 100644 --- a/lib/VMCore/Verifier.cpp +++ b/lib/VMCore/Verifier.cpp @@ -1072,6 +1072,18 @@ void Verifier::visitInstruction(Instruction &I) { InstsInThisBlock.insert(&I); } +static bool HasPtrPtrType(Value *Val) { + if (const PointerType *PtrTy = dyn_cast(Val->getType())) + return isa(PtrTy->getElementType()); + return false; +} + +static Value *StripBitCasts(Value *Val) { + if (BitCastInst *CI = dyn_cast(Val)) + return StripBitCasts(CI->getOperand(0)); + return Val; +} + /// visitIntrinsicFunction - Allow intrinsics to be verified in different ways. /// void Verifier::visitIntrinsicFunctionCall(Intrinsic::ID ID, CallInst &CI) { @@ -1082,6 +1094,30 @@ void Verifier::visitIntrinsicFunctionCall(Intrinsic::ID ID, CallInst &CI) { #define GET_INTRINSIC_VERIFIER #include "llvm/Intrinsics.gen" #undef GET_INTRINSIC_VERIFIER + + switch (ID) { + default: + break; + case Intrinsic::gcroot: + Assert1(HasPtrPtrType(CI.getOperand(1)), + "llvm.gcroot parameter #1 must be a pointer to a pointer.", &CI); + Assert1(isa(StripBitCasts(CI.getOperand(1))), + "llvm.gcroot parameter #1 must be an alloca (or a bitcast).", &CI); + Assert1(isa(CI.getOperand(2)), + "llvm.gcroot parameter #2 must be a constant or global.", &CI); + break; + case Intrinsic::gcwrite: + Assert1(CI.getOperand(3)->getType() + == PointerType::get(CI.getOperand(1)->getType()), + "Call to llvm.gcwrite must be with type 'void (%ty*, %ty2*, %ty**)'.", + &CI); + break; + case Intrinsic::gcread: + Assert1(CI.getOperand(2)->getType() == PointerType::get(CI.getType()), + "Call to llvm.gcread must be with type '%ty* (%ty2*, %ty**).'", + &CI); + break; + } } /// VerifyIntrinsicPrototype - TableGen emits calls to this function into diff --git a/test/CodeGen/Generic/GC/lower_gcroot.ll b/test/CodeGen/Generic/GC/lower_gcroot.ll index 3a3abac2585..2dbbc83569f 100644 --- a/test/CodeGen/Generic/GC/lower_gcroot.ll +++ b/test/CodeGen/Generic/GC/lower_gcroot.ll @@ -3,7 +3,8 @@ %Env = type opaque* define void @.main(%Env) { - call void @llvm.gcroot( %Env* null, %Env null ) + %Root = alloca %Env + call void @llvm.gcroot( %Env* %Root, %Env null ) unreachable } diff --git a/test/Verifier/gcread-ptrptr.ll b/test/Verifier/gcread-ptrptr.ll new file mode 100644 index 00000000000..bcfc6eb4f71 --- /dev/null +++ b/test/Verifier/gcread-ptrptr.ll @@ -0,0 +1,13 @@ +; RUN: not llvm-as < %s +; PR1633 + +%meta = type { i8* } +%obj = type { %meta* } + +declare %obj* @llvm.gcread(%obj*, %obj*) + +define %obj* @f() { +entry: + %x = call %obj* @llvm.gcread(%obj* null, %obj* null) + ret %obj* %x +} diff --git a/test/Verifier/gcroot-alloca.ll b/test/Verifier/gcroot-alloca.ll new file mode 100644 index 00000000000..c44321a065b --- /dev/null +++ b/test/Verifier/gcroot-alloca.ll @@ -0,0 +1,14 @@ +; RUN: not llvm-as < %s +; PR1633 + +%meta = type { i8* } +%obj = type { %meta* } + +declare void @llvm.gcroot(%obj**, %meta*) + +define void @f() { +entry: + call void @llvm.gcroot(%obj** null, %meta* null) + + ret void +} diff --git a/test/Verifier/gcroot-meta.ll b/test/Verifier/gcroot-meta.ll new file mode 100644 index 00000000000..51d19515afb --- /dev/null +++ b/test/Verifier/gcroot-meta.ll @@ -0,0 +1,16 @@ +; RUN: not llvm-as < %s +; PR1633 + +%meta = type { i8* } +%obj = type { %meta* } + +declare void @llvm.gcroot(%obj**, %meta*) + +define void @f() { +entry: + %local.obj = alloca %obj* + %local.meta = alloca %meta + call void @llvm.gcroot(%obj** %local.obj, %meta* %local.meta) + + ret void +} diff --git a/test/Verifier/gcroot-ptrptr.ll b/test/Verifier/gcroot-ptrptr.ll new file mode 100644 index 00000000000..0a7738d866c --- /dev/null +++ b/test/Verifier/gcroot-ptrptr.ll @@ -0,0 +1,14 @@ +; RUN: not llvm-as < %s +; PR1633 + +%meta = type { i8* } +%obj = type { %meta* } + +declare void @llvm.gcroot(%obj*, %meta*) + +define void @f() { +entry: + %local.obj = alloca %obj + call void @llvm.gcroot(%obj* %local.obj, %meta* null) + ret void +} diff --git a/test/Verifier/gcwrite-ptrptr.ll b/test/Verifier/gcwrite-ptrptr.ll new file mode 100644 index 00000000000..b1e96c8aa6e --- /dev/null +++ b/test/Verifier/gcwrite-ptrptr.ll @@ -0,0 +1,13 @@ +; RUN: not llvm-as < %s +; PR1633 + +%meta = type { i8* } +%obj = type { %meta* } + +declare void @llvm.gcwrite(%obj*, %obj*, %obj*) + +define void @f() { +entry: + call void @llvm.gcwrite(%obj* null, %obj* null, %obj* null) + ret void +}