Modernize raw_fd_ostream's constructor a bit.

Take a StringRef instead of a "const char *".
Take a "std::error_code &" instead of a "std::string &" for error.

A create static method would be even better, but this patch is already a bit too
big.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216393 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Rafael Espindola
2014-08-25 18:16:47 +00:00
parent a4c8f31dd0
commit 8c96862847
36 changed files with 181 additions and 192 deletions

View File

@ -16,8 +16,8 @@
#include "llvm/Support/Signals.h"
using namespace llvm;
tool_output_file::CleanupInstaller::CleanupInstaller(const char *filename)
: Filename(filename), Keep(false) {
tool_output_file::CleanupInstaller::CleanupInstaller(StringRef Filename)
: Filename(Filename), Keep(false) {
// Arrange for the file to be deleted if the process is killed.
if (Filename != "-")
sys::RemoveFileOnSignal(Filename);
@ -34,14 +34,13 @@ tool_output_file::CleanupInstaller::~CleanupInstaller() {
sys::DontRemoveFileOnSignal(Filename);
}
tool_output_file::tool_output_file(const char *filename, std::string &ErrorInfo,
tool_output_file::tool_output_file(StringRef Filename, std::error_code &EC,
sys::fs::OpenFlags Flags)
: Installer(filename), OS(filename, ErrorInfo, Flags) {
: Installer(Filename), OS(Filename, EC, Flags) {
// If open fails, no cleanup is needed.
if (!ErrorInfo.empty())
if (EC)
Installer.Keep = true;
}
tool_output_file::tool_output_file(const char *Filename, int FD)
: Installer(Filename), OS(FD, true) {
}
tool_output_file::tool_output_file(StringRef Filename, int FD)
: Installer(Filename), OS(FD, true) {}