Sort the incoming values in PHI nodes to match the predecessor order.

This helps expose duplicate PHIs, which will make it easier for them
to be eliminated.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@85623 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Dan Gohman 2009-10-30 22:22:22 +00:00
parent 0115e164ba
commit 8e42e4baae

View File

@ -10980,6 +10980,25 @@ Instruction *InstCombiner::visitPHINode(PHINode &PN) {
}
}
}
// Sort the PHI node operands to match the pred iterator order. This will
// help identical PHIs be eliminated by other passes. Other passes shouldn't
// depend on this for correctness however.
unsigned i = 0;
for (pred_iterator PI = pred_begin(PN.getParent()),
PE = pred_end(PN.getParent()); PI != PE; ++PI, ++i)
if (PN.getIncomingBlock(i) != *PI) {
unsigned j = PN.getBasicBlockIndex(*PI);
Value *VA = PN.getIncomingValue(i);
BasicBlock *BBA = PN.getIncomingBlock(i);
Value *VB = PN.getIncomingValue(j);
BasicBlock *BBB = PN.getIncomingBlock(j);
PN.setIncomingBlock(i, BBB);
PN.setIncomingValue(i, VB);
PN.setIncomingBlock(j, BBA);
PN.setIncomingValue(j, VA);
}
return 0;
}